- Notifications
You must be signed in to change notification settings - Fork61
chore: provide simplified interface to read/write CE for both binary and structured even formats#255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:v2
Are you sure you want to change the base?
Conversation
structured even formatsSigned-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
xSAVIKx left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@PlugaruT overall LGTM, please consider a couple of comments noted below
| deffrom_binary_event( | ||
| message:HTTPMessage, | ||
| event_format:Format|None=None, | ||
| )->BaseCloudEvent: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this should probably returnCloudEvent and notBaseCloudEvent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fair. Fixed
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
PlugaruT commentedDec 17, 2025
@xSAVIKx if it's all good after last commit, please merge if you'll approve. |
Changes
@xSAVIKx let me know what are your thoughts
One line description for the changelog