Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: implement http bindings#251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xSAVIKx merged 11 commits intocloudevents:v2fromPlugaruT:tudor/add-http-bindings
Nov 24, 2025

Conversation

@PlugaruT
Copy link

Changes

  • implement HTTP bindings for V2

One line description for the changelog

  • Tests pass
  • Appropriate changes to README are included in PR

Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
@PlugaruT
Copy link
Author

@xSAVIKx Can you please have a look when you are available 🙏

xSAVIKx reacted with thumbs up emoji

Copy link
Member

@xSAVIKxxSAVIKx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@PlugaruT thanks for the PR!

mypy has smth to say:

Image

And there are a couple of things I think we should do a bit differently but otherwise a good job 🙏

PlugaruT reacted with thumbs up emoji
Comment on lines 169 to 176
normalized_headers=_normalize_headers(message.headers)

attributes:Dict[str,Any]= {}

forheader_name,header_valueinnormalized_headers.items():
ifheader_name.startswith(CE_PREFIX):
attr_name=header_name[len(CE_PREFIX) :]
attributes[attr_name]=_decode_header_value(attr_name,header_value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

While this is factually a correct way we should take into account that CE are kinda low-level transport protocol messages. Creating a lot of intermediate objects here like doing this headers normalization may look like a small thing but will lead to bloating up resources consumption and while this is some new code, it may be a good opportunity to also think about doing this in an optimal way when possible.

it may be better to have a singlefor loop and do all the checks we want (CE-prefixed headers, content type header, etc) in a single run to avoid extra data structured and extra lookups.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's fair. Let me see what can I do.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done. Let me know if it's better

Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
@PlugaruT
Copy link
Author

@xSAVIKx this is ready again. I think I addressed your comments. Can you please review 🙏

xSAVIKx reacted with thumbs up emoji

@xSAVIKxxSAVIKx merged commitdb71318 intocloudevents:v2Nov 24, 2025
19 checks passed
@PlugaruTPlugaruT deleted the tudor/add-http-bindings branchNovember 25, 2025 14:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xSAVIKxxSAVIKxxSAVIKx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PlugaruT@xSAVIKx

[8]ページ先頭

©2009-2025 Movatter.jp