- Notifications
You must be signed in to change notification settings - Fork18
Introduce more cycling refactoring commands#95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Added:- clojure-ts-cycle-conditional- clojure-ts-cycle-not
Member
bbatsov commentedMay 14, 2025
Seems like a good idea to me. |
Uh oh!
There was an error while loading.Please reload this page.
bbatsov approved these changesMay 15, 2025
cca0e9f intoclojure-emacs:main 3 checks passed
Uh oh!
There was an error while loading.Please reload this page.
ContributorAuthor
rrudakov commentedMay 15, 2025
I forgot to add a reference to this PR to the changelog. |
Member
bbatsov commentedMay 15, 2025
I'll fix this myself. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the last cycling refactoring commands.
Added:
clojure-ts-cycle-conditionalclojure-ts-cycle-notclojure-modehas 2 separate commands:clojure-mode-cycle-ifandclojure-mode-cycle-when. Forclojure-ts-modeboth functions looked almost identical, so I decided to combine them into a single command. Not sure if it's a good idea, I can split it if necessary. I choose the keybindingC-c C-r C-cforclojure-ts-cycle-conditional, we can change it as well.Slightly adapted tests from
clojure-modepass successfully.Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!