Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Introduce more cycling refactoring commands#95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@rrudakov
Copy link
Contributor

These are the last cycling refactoring commands.

Added:

  • clojure-ts-cycle-conditional

  • clojure-ts-cycle-not

clojure-mode has 2 separate commands:clojure-mode-cycle-if andclojure-mode-cycle-when. Forclojure-ts-mode both functions looked almost identical, so I decided to combine them into a single command. Not sure if it's a good idea, I can split it if necessary. I choose the keybindingC-c C-r C-c forclojure-ts-cycle-conditional, we can change it as well.

Slightly adapted tests fromclojure-mode pass successfully.


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with ourcontribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've runM-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

Added:- clojure-ts-cycle-conditional- clojure-ts-cycle-not
@bbatsov
Copy link
Member

Not sure if it's a good idea, I can split it if necessary.

Seems like a good idea to me.

@rrudakovrrudakov requested a review frombbatsovMay 14, 2025 07:48
@bbatsovbbatsov merged commitcca0e9f intoclojure-emacs:mainMay 15, 2025
3 checks passed
@rrudakovrrudakov deleted the feature/finish-cycling branchMay 15, 2025 07:33
@rrudakov
Copy link
ContributorAuthor

I forgot to add a reference to this PR to the changelog.

@bbatsov
Copy link
Member

I'll fix this myself.

rrudakov reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bbatsovbbatsovbbatsov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rrudakov@bbatsov

[8]ページ先頭

©2009-2025 Movatter.jp