Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Introduce commands to convert collection type#92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@rrudakov
Copy link
Contributor

Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with ourcontribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've runM-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

@rrudakovrrudakovforce-pushed thefeature/convert-collection branch from1bba6ea toabfda1fCompareMay 9, 2025 18:51
@bbatsov
Copy link
Member

Overall the PR looks good. Might also be useful to add some cycle collection command that's a bit smarter and handles the most common cases:

  • list to quoted list
  • vector to map

@rrudakov
Copy link
ContributorAuthor

Overall the PR looks good. Might also be useful to add some cycle collection command that's a bit smarter and handles the most common cases:

  • list to quoted list
  • vector to map

Good idea. Maybe you could also suggest default keybinding for those commands?

@rrudakov
Copy link
ContributorAuthor

Overall the PR looks good. Might also be useful to add some cycle collection command that's a bit smarter and handles the most common cases:

  • list to quoted list
  • vector to map

On a second thought, I'm not sure about that :) You can convert list to quoted list by usingclojure-ts-convert-collection-to-quoted-list and you can convert vector to map usingclojure-ts-convert-collection-to-map, so the proposed functions will just duplicate the existing ones.

@rrudakovrrudakovforce-pushed thefeature/convert-collection branch fromabfda1f to155cb18CompareMay 10, 2025 06:16
@bbatsov
Copy link
Member

Yeah, I get this, but in my experience it’s quite uncommon to convert between most literal types. I meant this more in the sense of making it easier for the end users - by remembering less commands. Anyways, not very important right now.

@bbatsovbbatsov merged commitedf0d32 intoclojure-emacs:mainMay 10, 2025
3 checks passed
@rrudakovrrudakov deleted the feature/convert-collection branchMay 10, 2025 11:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bbatsovbbatsovbbatsov left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rrudakov@bbatsov

[8]ページ先頭

©2009-2025 Movatter.jp