Shouldn't this raise some error if the form at point is not threadable?

Inclojure-ts-mode it just returnsnil, I did the same here. Maybe because it's used in a loop in boththread-first-all andthread-last-all?

Much of the refactoring code was copied fromclj-refactor in bulk early on, so I didn't pay close attention to each command there - that's why I notice some stuff for the first time.

I think it probably makes sense to have an optional param controlling whether to raise an error or returnnil, and perhaps even introduce some lower-level function that's not actually command that all of the commands call. (extracted fromclojure-ts-thread)

Any rate - what you're doing right now is a great opportunity for us to examine closely each refactoring command and make them slightly better here and there in the process of porting them toclojure-ts-mode.

I agree, I already discovered a few issues inclojure-mode commands and fixed them inclojure-ts-mode implementation.

I updated this function, it signalsuser-error now if called interactively and there is no threading form.

I think it probably makes sense to have an optional param controlling whether to raise an error or returnnil, and perhaps even introduce some lower-level function that's not actually command that all of the commands call. (extracted fromclojure-ts-thread)

Perhaps we could look into it when we port more refactoring commands and see some pattern that can be extracted.