- Notifications
You must be signed in to change notification settings - Fork18
Add unwind refactoring commands#88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add unwind refactoring commands#88
Uh oh!
There was an error while loading.Please reload this page.
Conversation
0759b39 to2db43a4CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
bbatsov commentedApr 28, 2025
Apart from my small inline remarks I can suggest also:
Overall, the PR looks good to me, though. |
rrudakov commentedApr 28, 2025
Could you please suggest a command name for that?
Sure. I'm planning to port refactoring commands from
Thanks! I'll fix all the issues. |
2db43a4 tof6ef592Comparebbatsov commentedApr 28, 2025
Perhaps something like |
bbatsov commentedApr 28, 2025
I figured something like this was the case. :-) |
rrudakov commentedApr 28, 2025
After giving it some thoughts, I think it would be better to implement in a separate PR. Ideally this would require defining a new minor mode |
f6ef592 to97bde83Comparebbatsov commentedApr 29, 2025
No, that's more or less what I normally do in such situations. It's fairly simple and standard - you can use |
4bdd7f2 intoclojure-emacs:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The new commands work the same as in
clojure-modewith one improvement (hopefully):In
clojure-modeunwinding form(-> foo bar)would produce(-> (bar foo)), so you need to run unwind command one more time to get rid of threading macro. Inclojure-ts-modeit will produce(bar foo)immediately. Because of that I had to adapt tests fromclojure-modea little bit.Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!