Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Implementclojure-ts-align#83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@rrudakov
Copy link
Contributor

@rrudakovrrudakov commentedApr 18, 2025
edited
Loading

First part for#16

The code is adapted fromclojure-mode, but I usedtreesit-* API wherever it was appropriate and possible. The most difficult part is dealing with metadata, I left comments describing how it works.

The function is bound toC-c SPC inclojure-ts-mode-map, similar toclojure-mode.

I also disabledtab-indent-mode by default forclojure-ts-mode, similar toclojure-mode, otherwise it tries to use tabs for alignment and sometimes it looks ugly.


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with ourcontribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've runM-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

@rrudakovrrudakovforce-pushed thefeature/16-align-forms branch from69f9fa9 tob9d8ae1CompareApril 18, 2025 16:12
@rrudakovrrudakov marked this pull request as draftApril 18, 2025 16:17
@rrudakovrrudakovforce-pushed thefeature/16-align-forms branch fromb9d8ae1 to15434f0CompareApril 18, 2025 18:24
@rrudakovrrudakov marked this pull request as ready for reviewApril 18, 2025 18:24
@rrudakov
Copy link
ContributorAuthor

The initial version was very slow, so I had to do some optimizations. Now it's pretty fast even in large buffers.

@rrudakovrrudakovforce-pushed thefeature/16-align-forms branch from15434f0 to2ad63f5CompareApril 18, 2025 18:32
@rrudakovrrudakovforce-pushed thefeature/16-align-forms branch from2ad63f5 to862d391CompareApril 21, 2025 16:48
@rrudakov
Copy link
ContributorAuthor

rrudakov commentedApr 23, 2025
edited
Loading

Anybody?@bbatsov?

@bbatsov
Copy link
Member

I'm always around. ;-)

@rrudakov
Copy link
ContributorAuthor

I'm always around. ;-)

Sorry for pinging you :) Could you please review this when you have a chance?

I'd like to contribute more, but I don't want to keep many conflicting branches in my fork.

@bbatsovbbatsov merged commit61041c8 intoclojure-emacs:mainApr 23, 2025
3 checks passed
@bbatsov
Copy link
Member

The changes look great! Impressive work!

rrudakov reacted with hooray emoji

@rrudakovrrudakov deleted the feature/16-align-forms branchApril 23, 2025 10:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rrudakov@bbatsov

[8]ページ先頭

©2009-2025 Movatter.jp