- Notifications
You must be signed in to change notification settings - Fork18
Implementclojure-ts-align#83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
69f9fa9 tob9d8ae1Compareb9d8ae1 to15434f0Comparerrudakov commentedApr 18, 2025
The initial version was very slow, so I had to do some optimizations. Now it's pretty fast even in large buffers. |
15434f0 to2ad63f5Compare2ad63f5 to862d391Comparerrudakov commentedApr 23, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Anybody?@bbatsov? |
bbatsov commentedApr 23, 2025
I'm always around. ;-) |
rrudakov commentedApr 23, 2025
Sorry for pinging you :) Could you please review this when you have a chance? I'd like to contribute more, but I don't want to keep many conflicting branches in my fork. |
61041c8 intoclojure-emacs:mainUh oh!
There was an error while loading.Please reload this page.
bbatsov commentedApr 23, 2025
The changes look great! Impressive work! |
Uh oh!
There was an error while loading.Please reload this page.
First part for#16
The code is adapted from
clojure-mode, but I usedtreesit-*API wherever it was appropriate and possible. The most difficult part is dealing with metadata, I left comments describing how it works.The function is bound to
C-c SPCinclojure-ts-mode-map, similar toclojure-mode.I also disabled
tab-indent-modeby default forclojure-ts-mode, similar toclojure-mode, otherwise it tries to use tabs for alignment and sometimes it looks ugly.Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!