- Notifications
You must be signed in to change notification settings - Fork18
Improve performance of semantic indentation by caching rules#76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
bbatsov merged 1 commit intoclojure-emacs:mainfromrrudakov:feature/semantic-indentation-performance-improvementsApr 10, 2025
Merged
Improve performance of semantic indentation by caching rules#76
bbatsov merged 1 commit intoclojure-emacs:mainfromrrudakov:feature/semantic-indentation-performance-improvementsApr 10, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
d76c16f to9dff9d1CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
9dff9d1 tob57f024Comparebbatsov approved these changesApr 10, 2025
897659a intoclojure-emacs:main 2 of 3 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that reindenting big file is pretty slow, profiler report indicated that the bottleneck is the calculation of combined indentation rules from default settings and user customizations:
this is called every time we need to calculate indentation for a single line.
This PR introduces buffer local variable
clojure-ts--semantic-indent-rules-cachewhich stores pre-calculated rules. This variable is set whenclojure-ts-modeis activated and updated every time whenclojure-ts-semantic-indent-rulesis updated or file local variables are updated (in case when indentation rules are defined in.dir-locals.elfor example.Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!