- Notifications
You must be signed in to change notification settings - Fork18
Pass fully qualified symbol to clojure-ts-get-indent-function#72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Pass fully qualified symbol to clojure-ts-get-indent-function#72
Uh oh!
There was an error while loading.Please reload this page.
Conversation
0ae25b4 tobaca35bComparebbatsov commentedApr 5, 2025
Ah, yeah - I had forgotten about this, but it's kind of important, otherwise it's not possible to tell apart indentation metadata for the same symbols in different namespaces. Probably in |
Uh oh!
There was an error while loading.Please reload this page.
baca35b to3761b2dComparerrudakov commentedApr 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hmm, that's a good point, if macro is defined in the same namespace then this function will be called without ns in current implementation, but macro can also be required using |
rrudakov commentedApr 5, 2025
@bbatsov I'd probably suggest to merge this as is. I'll try to figure out how to deal with edge cases separately. |
rrudakov commentedApr 5, 2025
I've just tested it with CIDER, if a macro is imported using |
c213950 intoclojure-emacs:mainUh oh!
There was an error while loading.Please reload this page.
bbatsov commentedApr 5, 2025
Deal! |
When I started testing it with CIDER I realized that we have to pass fully qualified symbol name to
cider--get-symbol-indent, otherwise it won't resolve it and won't return indentation metadata.Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!