Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve syntax highlighting#66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@rrudakov
Copy link
Contributor

Fix a few issues with syntax highlighting I discovered.

Before:
image

image

image

After:
image

image

image

There were failing tests inclojure-ts-mode-font-lock-test.el (not sure how did they pass CI before), those are fixed now.


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with ourcontribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've runM-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

@rrudakovrrudakovforce-pushed thefeature/improve-syntax-highlighting branch from5e8a7d2 to3ceb0a6CompareMarch 22, 2025 19:59
@rrudakov
Copy link
ContributorAuthor

Looks like linter doesn't like;; Package-Requires: ((emacs "30.1"))

@bbatsov
Copy link
Member

@rrudakov I'm aware of this and I had openedpurcell/package-lint#292

Overall it seems to me that aiming to support Emacs 29 doesn't make much sense due to the moving nature of the TreeSitter support, but package-lint needs to be updated for the CI to pass or we need to revert the changes dropping Emacs 29 support.

@rrudakov
Copy link
ContributorAuthor

@bbatsov can we maybe merge it like this and deal with the linter separately?

@bbatsov
Copy link
Member

Yeah, the linter is not an issue at all - I was just responding to the remark about it. At a glance your changes seem fine to me, but I wanted to take a closer look.

rrudakov reacted with thumbs up emoji

@bbatsovbbatsov merged commitf932fc3 intoclojure-emacs:mainMar 25, 2025
2 of 3 checks passed
@bbatsov
Copy link
Member

All the changes look good to me. Thanks!

rrudakov reacted with hooray emoji

@rrudakovrrudakov deleted the feature/improve-syntax-highlighting branchMarch 25, 2025 09:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rrudakov@bbatsov

[8]ページ先頭

©2009-2025 Movatter.jp