- Notifications
You must be signed in to change notification settings - Fork18
Improve syntax highlighting#66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Improve syntax highlighting#66
Uh oh!
There was an error while loading.Please reload this page.
Conversation
5e8a7d2 to3ceb0a6Comparerrudakov commentedMar 22, 2025
Looks like linter doesn't like |
bbatsov commentedMar 24, 2025
@rrudakov I'm aware of this and I had openedpurcell/package-lint#292 Overall it seems to me that aiming to support Emacs 29 doesn't make much sense due to the moving nature of the TreeSitter support, but package-lint needs to be updated for the CI to pass or we need to revert the changes dropping Emacs 29 support. |
rrudakov commentedMar 24, 2025
@bbatsov can we maybe merge it like this and deal with the linter separately? |
bbatsov commentedMar 24, 2025
Yeah, the linter is not an issue at all - I was just responding to the remark about it. At a glance your changes seem fine to me, but I wanted to take a closer look. |
f932fc3 intoclojure-emacs:mainUh oh!
There was an error while loading.Please reload this page.
bbatsov commentedMar 25, 2025
All the changes look good to me. Thanks! |
Fix a few issues with syntax highlighting I discovered.
Before:

After:

There were failing tests in
clojure-ts-mode-font-lock-test.el(not sure how did they pass CI before), those are fixed now.Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!