Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add defcustom for major-mode remapping#64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bbatsov merged 3 commits intoclojure-emacs:mainfromyuhan0:optional-remap
Mar 8, 2025

Conversation

@yuhan0
Copy link
Contributor

Closes#63

Naming of defcustom / commands open to change, if alright I can go ahead and edit the changelog/Readme


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • You've runM-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

@bbatsov
Copy link
Member

Looks good.

I noticedclojure-ts-mode also adds separate modes and mappings for jank and ClojureDart, and I thinkclojure-mode that just maps them toclojure-mode, but we can address this discrepancy.

:safe#'booleanp
:package-version '(clojure-ts-mode."0.2.3"))

(defcustomclojure-ts-auto-redirectt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perhapsclojure-ts-auto-remap orclojure-ts-auto-remap-modes would be slightly better name.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've renamed it toclojure-ts-auto-remap, wasn't sure if it should have a-p suffix being a boolean? Feel free to change it further (maybe the commands too,clojure-ts-activate ->clojure-ts-activate-remapping)

@yuhan0
Copy link
ContributorAuthor

I've removed the commit which uses defcustom setter to trigger activate/deactivate calls onsetopt, after a few attempts at fixing it was still causing recursive load errors when being called on initial package load.

@bbatsovbbatsov merged commitf5f377a intoclojure-emacs:mainMar 8, 2025
0 of 3 checks passed
@bbatsov
Copy link
Member

Okay, I guess that will do for now. I thought a bit too late that probably those commands shouldn't do anything ifclojure-mode is not around, but I doubt anyone would call them if they don't useclojure-mode to some extent.

@rrudakov
Copy link
Contributor

@bbatsov
Copy link
Member

Good to know, I'll update the code to use it.

rrudakov reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bbatsovbbatsovbbatsov left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuhan0@bbatsov@rrudakov

[8]ページ先頭

©2009-2025 Movatter.jp