- Notifications
You must be signed in to change notification settings - Fork18
Introduceclojure-ts-extra-def-forms customization#104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
bbatsov merged 2 commits intoclojure-emacs:mainfromrrudakov:feature/15-extra-def-font-lockMay 31, 2025
Merged
Introduceclojure-ts-extra-def-forms customization#104
bbatsov merged 2 commits intoclojure-emacs:mainfromrrudakov:feature/15-extra-def-font-lockMay 31, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Remove 'append' from clojure-ts--align-query and extend it to match :letvector in 'for' and 'doseq' forms.- Remove hack with setting ':override t' for embedded parsers; it was addedbefore I figured out how to not fontify some strings.
82c4b33 intoclojure-emacs:main 3 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Member
bbatsov commentedMay 31, 2025
I agree that's more than enough at this point. Great work! |
rrudakov added a commit to rrudakov/clojure-ts-mode that referenced this pull requestJun 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially (or fully?) addresses#15
In this PR I only added
clojure-ts-extra-def-formsvariable. I think we can add low-level customization if there is a request for that. For now dynamic font-lock from CIDER and this variable should cover most of the users needs.Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!