- Notifications
You must be signed in to change notification settings - Fork18
Inlinetreesit-query-p to ensure compatibility with Emacs 30#102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
clojure-ts-mode.el Outdated
| a query that is valid in a previous grammar version but invalid in the | ||
| required version." | ||
| (treesit-query-valid-p'clojure '((sym_lit (meta_lit))))) | ||
| (ignore-errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This doesn't look like inlining to me. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would you prefer to define a separate function?
I just replaced thetreesit-query-valid-p call with it's implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, I didn't realize at first that the implementation was so simple. Still, I prefer a separate function so it'd be more likely we remember to replace it withtreesit-query-valid-p when the time comes.
74de948 tob9b03d4Compare5df8343 intoclojure-emacs:mainUh oh!
There was an error while loading.Please reload this page.
Follow up#99 (comment)