- Notifications
You must be signed in to change notification settings - Fork18
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default Checking mergeability… Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:clojure-emacs/clojure-ts-mode
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:main
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:clojure-emacs/clojure-ts-mode
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:regular-expression-font-locking
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
Uh oh!
There was an error while loading.Please reload this page.
- 2commits
- 3files changed
- 1contributor
Commits on Aug 27, 2023
Highlight regular expressions with tree-sitter-regex grammar
This grammar is bundled in nixos by default and seems good enough forjava regular expressions. It is also maintained under the tree-sittergithub org so is "official".In order to property identify the #" and closing " characters we have toparse them with the clojure grammar (in case the regex grammar is notavailable) and again with the regex grammar as part of the actualpattern. This could be avoided if either the clojure grammar captured anode for the inner contents of the regex literal, or thetreesit-range-settings supported some kind of offest argument like theneovim tree-sitter mechanisms do.Should address issue#11I think that multiple parsers per buffer may be too buggy to use rightnow. There are situations where no regex will be present on in a buffer,but the entire buffer will be highlighted as a regular expression. Thisfunctionality probably needs upstream work in Emacs before we can mergethis into the main branch of clojure-ts-mode
dannyfreeman committedAug 27, 2023 Add CHANGELOG entry about regex font-locking feature
dannyfreeman committedAug 27, 2023
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff main...regular-expression-font-locking
Uh oh!
There was an error while loading.Please reload this page.