Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork649
cider-eval
: support re-rendering the Inspector buffer whencider-inspector-auto-select-buffer
is set to nil and there's a*cider-inspect*
buffer shown in a non-visible frame#3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…sible in another frame and `select` is nilThis seems the right thing to do.
…nspector-auto-select-buffer` is set to nil and there's a `*cider-inspect*` buffer shown in a non-visible frameThis supports the workflow of using the inspector occasionally (less intrusively), but ready to be shown anytime.
If there's already a `*cider-inspect*` buffer visible, we shouldn't suggest the user to inspect the value again.
66b577d
to657b2d3
Comparecider-eval
: Introduce newcider-auto-inspect-after-eval-select-window
defcustomcider-eval
: support re-rendering the Inspector buffer whencider-inspector-auto-select-buffer
is set to nil and there's a*cider-inspect*
buffer shown in a non-visible frameI reworked this PR to not introduce any defcustoms - ready now! |
Thanks for the update, I'll review it tomorrow. |
@@ -826,6 +826,24 @@ KIND can be the symbols `ns', `var', `emph', `fn', or a face name." | |||
(t x))) | |||
menu-list)) | |||
;; Defined here to avoid circular dependencies | |||
(defconst cider-inspector-buffer "*cider-inspect*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hmm, I'm not sure I like this, because the way I see it the inspector shouldn't be depending oncider-eval
and now we're kind of sweeping this odd dependency under the rug.
bbatsov commentedApr 21, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I checked the |
@alexander-yakushev Any thoughts on this PR? |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed soon if no further activity occurs. Thank you for your contribution and understanding! |
Uh oh!
There was an error while loading.Please reload this page.
My overall intent is the possibility to have the
*cider-inspect*
buffer permanently on a background frame. cider-eval would have that frame's cider-inspect buffer re-rendered,without switching to it, given that I personally find that only a fraction of evals deserve inspection.This wasn't possible before, as CIDER would detect that my frame wasn't visible, so it would render the buffer in a random window of the visible frame.
Commits:
cider-popup-buffer-display
: Do nothing if the intended buffer is visible in another frame andselect
is nilcider-eval
: support re-rendering the Inspector buffer whencider-inspector-auto-select-buffer
is set to nil and there's a*cider-inspect*
buffer shown in a non-visible frameResult truncated
message more accurate*cider-inspect*
buffer visible, we shouldn't suggest the user to inspect the value again.Cheers - V