Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

cider-eval: support re-rendering the Inspector buffer whencider-inspector-auto-select-buffer is set to nil and there's a*cider-inspect* buffer shown in a non-visible frame#3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
vemv wants to merge3 commits intomaster
base:master
Choose a base branch
Loading
fromcider-inspect-defcustoms

Conversation

vemv
Copy link
Member

@vemvvemv commentedMar 14, 2024
edited
Loading

My overall intent is the possibility to have the*cider-inspect* buffer permanently on a background frame. cider-eval would have that frame's cider-inspect buffer re-rendered,without switching to it, given that I personally find that only a fraction of evals deserve inspection.

This wasn't possible before, as CIDER would detect that my frame wasn't visible, so it would render the buffer in a random window of the visible frame.

Commits:

  • cider-popup-buffer-display: Do nothing if the intended buffer is visible in another frame andselect is nil
    • This seems the right thing to do, for a wide variety of use cases.
  • cider-eval: support re-rendering the Inspector buffer whencider-inspector-auto-select-buffer is set to nil and there's a*cider-inspect* buffer shown in a non-visible frame
    • This supports the workflow of using the inspector occasionally (less intrusively), but ready to be shown anytime.
  • cider-overlays: MakeResult truncated message more accurate
    • If there's already a*cider-inspect* buffer visible, we shouldn't suggest the user to inspect the value again.

Cheers - V

…sible in another frame and `select` is nilThis seems the right thing to do.
@vemvvemv requested a review frombbatsovMarch 14, 2024 07:52
@vemvvemv marked this pull request as draftMarch 14, 2024 11:11
…nspector-auto-select-buffer` is set to nil and there's a `*cider-inspect*` buffer shown in a non-visible frameThis supports the workflow of using the inspector occasionally (less intrusively), but ready to be shown anytime.
If there's already a `*cider-inspect*` buffer visible, we shouldn't suggest the user to inspect the value again.
@vemvvemvforce-pushed thecider-inspect-defcustoms branch from66b577d to657b2d3CompareMarch 14, 2024 11:28
@vemvvemv changed the titlecider-eval: Introduce newcider-auto-inspect-after-eval-select-window defcustomcider-eval: support re-rendering the Inspector buffer whencider-inspector-auto-select-buffer is set to nil and there's a*cider-inspect* buffer shown in a non-visible frameMar 14, 2024
@vemvvemv marked this pull request as ready for reviewMarch 14, 2024 11:36
@vemv
Copy link
MemberAuthor

I reworked this PR to not introduce any defcustoms - ready now!

@bbatsov
Copy link
Member

Thanks for the update, I'll review it tomorrow.

@@ -826,6 +826,24 @@ KIND can be the symbols `ns', `var', `emph', `fn', or a face name."
(t x)))
menu-list))

;; Defined here to avoid circular dependencies
(defconst cider-inspector-buffer "*cider-inspect*")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hmm, I'm not sure I like this, because the way I see it the inspector shouldn't be depending oncider-eval and now we're kind of sweeping this odd dependency under the rug.

@bbatsov
Copy link
Member

bbatsov commentedApr 21, 2024
edited
Loading

I checked thecider-inspector.el code and it seems the dependency oncider-eval.el is there just to access a single variable from there. Perhaps a better fix would be a simpledeclare or removing that prefix. After all we're not really doing an eval here anyways.

@bbatsov
Copy link
Member

@alexander-yakushev Any thoughts on this PR?

@github-actionsGitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed soon if no further activity occurs. Thank you for your contribution and understanding!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bbatsovbbatsovbbatsov left review comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@vemv@bbatsov

[8]ページ先頭

©2009-2025 Movatter.jp