- Notifications
You must be signed in to change notification settings - Fork790
Add support for the Bun and pnpm package managers.#231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
commiterate wants to merge1 commit intoclojure:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
418d878 tod713463Compared713463 to45cabc0CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
Mirroring a similar contribution to shadow-cljs.
See the shadow-cljs issue for a more detailed "why".
This also adds support for
node_modulesindexing with the Bun runtime.Testing
I've avoided adding additional tests in
src/test/clojure/cljs/foreign/node_test.cljfor the time being since I'm not sure how the ClojureScript CI environment is configured (not sure if Bun and pnpm are available).Instead, I created a test repository with a barebones CLJS project using the fork (sourced in
deps.ednwith thegitprocurer).https://github.com/commiterate/test-clojurescript-bun
This repository usesEmmy to create a Node.js application that just prints 21 (using Emmy's
exp2function) to stdout.A reproducible shell is provided with Nix for additional testing by the ClojureScript team and others.
There's notes in the test repository's readme detailing some sharp edges with:
tools.build(classpath issues breakingdeps.cljssearches).These might be of interest to the ClojureScript team for future improvements.