Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Layer helper has a broken check for inset configuration #7

Open
@arcresu

Description

@arcresu

build_sf_inset_layers() decides whether or not to add an inset layer based onis.null(inset). This is wrong, because layers are supposed to default toinset = NA so that it's controlled by the coord. This doesn't work though since the layer helper is trying to make the decision at plot configuration time, whereas the inset config in the coord won't be known until too late, at build time. The result is that the default creates an incorrect duplicate copy of the sf layer (seecidm-ph/ggautomap#5).

It seems like the proper fix would be to emit both layers in the layer helper when using theauto mode, and have that secondary layer drawn nothing in the case that there is no inset config in the coord.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp