Deployed to Maven Central#9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Anmol202005 wants to merge1 commit intocheckstyle:main

base:main

Choose a base branch

fromAnmol202005:deploy

Open

Deployed to Maven Central#9

Anmol202005 wants to merge1 commit intocheckstyle:mainfromAnmol202005:deploy

Conversation

Copy link

Collaborator

Anmol202005 commentedJun 8, 2025

Fixes:#6
Configured pom.xml for maven central deployment.

Deployed to Maven Central

cf6017b

romani reviewed

Jun 8, 2025

View reviewed changes

pom.xml

		<artifactId>oss-parent</artifactId>
		<version>9</version>
		</parent>

		<groupId>org.checkstyle.autofix</groupId>

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we canorg.checkstyle only for group.
it is ok to have plugins/tools to be just under "checkstyle"

Copy link

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In the patch-filter project I see latest master has<groupId>com.puppycrawl.tools</groupId>, shall we go with the same groupId? Better to agree on this now while we are still at the start of the project

Copy link

Member

romaniJun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

https://repo1.maven.org/maven2/org/checkstyle

Is not existing, so it means it will be a special process to claim ownership of such domain.

Lets use group common for all , as Ruslan suggested
https://repo1.maven.org/maven2/com/puppycrawl/tools/

Copy link

Member

romani commentedJun 8, 2025

I think we should not be obsessed to deploy to maven central jar too early.

We can always put jar to maven local repository and use special profile to activate openrewrite to fix code.

scenario:
user do code changes
use run "mvn verify"
it failing with errors
user run "mvn ..... -Pautofix" to fix violations.

it will help us take maturity withtout bothering much existing dev process of checkstyle. We will share knowledge on this, so users will likely to run it manually and give feedback and not be blocked if any problems happens with auto-fixes.