Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.8k
Issue #17223: implementation of Indentation TextBlockGoogleStyleFormattingCheck#17395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
XpathRegression..Tests only support one error per test. but this Check always logs two violations because#17284 (comment) |
Zopsss commentedJul 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
We're duplicating much code here. Ideally, the whole check should be part of a single PR, so indentation functionality should be implemented in the original PR. But if you want, you can test indentation in this PR and then copy the commit to the main PR once it's basic functionality ( main PR's basic functionality ) is implemented. |
| final String[] expectedViolation = { | ||
| "7:14: " + getCheckMessage(CLASS, | ||
| TextBlockGoogleStyleFormattingCheck.MSG_CLOSE_QUOTES_ERROR), | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just add the required violation msg here to pass the test. Violation is correct because quotes aren't aligned properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
But if you want, you can test indentation in this PR
yes, this pr is for testing mainly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just add the required violation msg here to pass the test
that's the problem. not possible. multiple violations are not supported in Xpath... tests.
but we need the Check to give two violations#17284 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@romani can you tell why multiple violations are not supported in XPath tests?
Uh oh!
There was an error while loading.Please reload this page.
part of#17223
Added indentation feature to check if quotes are vertically aligned.
test only PR. NOT TO BE MERGED