Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.8k
Issue #16361: Update DefaultLoggerTest.java to verify with InlineConfigParser and logger#17370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…InlineConfigParser and logger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
testing exceptional cases by means end-to-end might be challenging.
if you will have problems to make it work, itis ok keep such test methods as is.
We usually allow not end-to-end for testing that exception is thrown.
| <!-- Intentionally unparsable files--> | ||
| <modulename="BeforeExecutionExclusionFileFilter"> | ||
| <propertyname="fileNamePattern" | ||
| value="defaultlogger[\\/]InputDefaultLoggerTestCtor\.java"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we have "non-compiled" folder in resources, if you place here you might not need this Filter
It's been a while :)
Issue#16361
verifyWithInlineConfigParserAndLoggerTwoStreamsinAbstractModuleTestSupportfor loggers with two output streams. One test case inDefaultLoggerTest.javais converted to the new approach as an example with a case of parsing exception logged as error.I needed to change the default
haltOnExceptionvalue fromtruetofalseso the exception would be logged instead of bubbling up. Therefore, I use the fullCheckerconfiguration.The stack trace output is trimmed to its first line.