Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit64edf2a

Browse files
mureinikromani
authored andcommitted
Issue#18074: Align slf4j version to the version reflections uses, and mark as runtime dep
1 parentbfd8fea commit64edf2a

File tree

2 files changed

+39
-5
lines changed

2 files changed

+39
-5
lines changed

‎.ci/validation.sh‎

Lines changed: 36 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -450,17 +450,51 @@ assembly-run-all-jar)
450450
mkdir -p .ci-temp
451451
FOLDER=src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule73wherejavadocrequired
452452
FILE=InputMissingJavadocTypeCorrect.java
453+
echo"Execution with plain text report"
453454
java -jar target/checkstyle-"$CS_POM_VERSION"-all.jar -c /google_checks.xml \
454455
$FOLDER/$FILE> .ci-temp/output.log
455456
fail=0
456457
if grep -vE'(Starting audit)|(warning)|(Audit done.)' .ci-temp/output.log;then
457458
fail=1;
459+
exit$fail;
458460
elif grep'warning' .ci-temp/output.log;then
459461
fail=1;
462+
exit$fail;
460463
fi
461464
rm .ci-temp/output.log
462-
sleep 5
463-
exit$fail
465+
echo"Execution with xml report"
466+
java -jar target/checkstyle-"$CS_POM_VERSION"-all.jar -f xml -c /google_checks.xml \
467+
$FOLDER/$FILE -o .ci-temp/output.xml
468+
fail=0
469+
echo"Content of report:"
470+
cat .ci-temp/output.xml
471+
echo"Validation of report"
472+
if! grep'</checkstyle>' .ci-temp/output.xml;then
473+
fail=1;
474+
echo"no closed tag"
475+
exit$fail;
476+
elif! grep'file name' .ci-temp/output.xml;then
477+
fail=1;
478+
echo"no file tag"
479+
exit$fail;
480+
fi
481+
rm .ci-temp/output.xml
482+
echo"Execution with sarif report"
483+
java -jar target/checkstyle-"$CS_POM_VERSION"-all.jar -f sarif -c /google_checks.xml \
484+
$FOLDER/$FILE -o .ci-temp/output.json
485+
fail=0
486+
echo"Content of report:"
487+
cat .ci-temp/output.json
488+
echo"Validation of report"
489+
if! grep'downloadUri' .ci-temp/output.json;then
490+
fail=1;
491+
exit$fail;
492+
elif! grep'results' .ci-temp/output.json;then
493+
fail=1;
494+
exit$fail;
495+
fi
496+
rm .ci-temp/output.json
497+
464498
;;
465499

466500
check-since-version)

‎pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@
208208
<pmd.version>7.18.0</pmd.version>
209209
<maven.jacoco.plugin.version>0.8.14</maven.jacoco.plugin.version>
210210
<mockito.version>5.2.0</mockito.version>
211-
<slf4j.version>2.0.17</slf4j.version>
211+
<slf4j.version>1.7.32</slf4j.version><!-- Aligned with the version reflections depends on-->
212212
<saxon.version>12.9</saxon.version>
213213
<maven.checkstyle.plugin.version>3.6.0</maven.checkstyle.plugin.version>
214214
<maven.sevntu.checkstyle.plugin.version>1.44.1</maven.sevntu.checkstyle.plugin.version>
@@ -426,13 +426,13 @@
426426
<groupId>org.slf4j</groupId>
427427
<artifactId>slf4j-api</artifactId>
428428
<version>${slf4j.version}</version>
429-
<scope>test</scope>
429+
<scope>runtime</scope>
430430
</dependency>
431431
<dependency>
432432
<groupId>org.slf4j</groupId>
433433
<artifactId>slf4j-simple</artifactId>
434434
<version>${slf4j.version}</version>
435-
<scope>test</scope>
435+
<scope>runtime</scope>
436436
</dependency>
437437
<dependency>
438438
<groupId>org.jacoco</groupId>

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp