Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Enable change of prefixes to existing options proxy#11105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
stockiNail wants to merge2 commits intochartjs:master
base:master
Choose a base branch
Loading
frompepstock-org:prefixes

Conversation

stockiNail
Copy link
Contributor

Fix#11104

This PR is extending the prefixes to sub-nodes.

@stockiNail
Copy link
ContributorAuthor

@kurkle this PR should also enable the'hover' options in subnodes (labels and captions), needed forchartjs-chart-treemap as well.

kurkle/chartjs-chart-treemap#175 (comment)

@stockiNail
Copy link
ContributorAuthor

@etimberg@kurkle I set this PR in draft (to avoid any approval) because it must be changed, going to TS, after#11121 merged.

@stockiNailstockiNail marked this pull request as ready for reviewMarch 22, 2023 09:08
@stockiNail
Copy link
ContributorAuthor

@dangreen@etimberg@kurkle I have changed going to TS (hopefully correctly). Available for your review.

@stockiNail
Copy link
ContributorAuthor

@kurkle
Copy link
Member

Looks like I dropped the ball with this 😞
I have no idea, why a sub resolver would not just inherit the prefixes in _resolveWithPrefixes.
But if it could be made there, nothing special would need to be done in plugins (it would be a breaking change though).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kurklekurkleAwaiting requested review from kurkle

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update prefixes to already existing proxy
4 participants
@stockiNail@kurkle@etimberg@LeeLenaleee
[8]ページ先頭
©2009-2025 Movatter.jp