Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Start moving lecacy scale hooks to plugin#10631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
LeeLenaleee wants to merge1 commit intochartjs:master
base:master
Choose a base branch
Loading
fromLeeLenaleee:move-legacy-scale-hooks-to-plugin

Conversation

LeeLenaleee
Copy link
Collaborator

@LeeLenaleeeLeeLenaleee commentedAug 25, 2022
edited
Loading

Resolves#10155

TODO:

@etimberg you added the breaking change to it but in its current form its not breaking right since it still calls the hooks like it used to or do you want to have thecall (line 527) here also removed?

_callHooks(name){
this.chart.notifyPlugins(name,this.getContext());
call(this.options[name],[this]);
}

@etimberg
Copy link
Member

Yeah, I had thought we could remove line 527 so that it only goes to plugins and avoids these option callbacks

LeeLenaleee reacted with thumbs up emoji

@etimberg
Copy link
Member

@LeeLenaleee@kurkle do we still want this in v4? It's the last thing

@LeeLenaleee
Copy link
CollaboratorAuthor

Every time I look at the test i can't seem to make them work so stopped looking at it, will give it another look Monday evening see if a fresh look sees what I did wrong and otherwise we can either skip it or someone else has to fix the test

etimberg reacted with thumbs up emoji

@etimberg
Copy link
Member

I'm thinking we should skip this and move it to v5 at this point. Thoughts@LeeLenaleee@kurkle@dangreen ?

dangreen and kurkle reacted with thumbs up emoji

@LeeLenaleee
Copy link
CollaboratorAuthor

Agree

dangreen reacted with thumbs up emoji

1 similar comment
@dangreen
Copy link
Collaborator

Agree

@LeeLenaleeeLeeLenaleee deleted the move-legacy-scale-hooks-to-plugin branchJanuary 15, 2024 17:12
@LeeLenaleeeLeeLenaleee restored the move-legacy-scale-hooks-to-plugin branchJanuary 15, 2024 21:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
Version 5.0.0
Development

Successfully merging this pull request may close these issues.

Convert Scale Legacy Callbacks to Plugin Hooks
3 participants
@LeeLenaleee@etimberg@dangreen

[8]ページ先頭

©2009-2025 Movatter.jp