- Notifications
You must be signed in to change notification settings - Fork12k
Start moving lecacy scale hooks to plugin#10631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Start moving lecacy scale hooks to plugin#10631
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Yeah, I had thought we could remove line 527 so that it only goes to plugins and avoids these option callbacks |
@LeeLenaleee@kurkle do we still want this in v4? It's the last thing |
Every time I look at the test i can't seem to make them work so stopped looking at it, will give it another look Monday evening see if a fresh look sees what I did wrong and otherwise we can either skip it or someone else has to fix the test |
I'm thinking we should skip this and move it to v5 at this point. Thoughts@LeeLenaleee@kurkle@dangreen ? |
Agree |
1 similar comment
Agree |
Uh oh!
There was an error while loading.Please reload this page.
Resolves#10155
TODO:
@etimberg you added the breaking change to it but in its current form its not breaking right since it still calls the hooks like it used to or do you want to have the
call
(line 527) here also removed?Chart.js/src/core/core.scale.js
Lines 525 to 528 inf957aad