Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

fix: Include CGridItem in type definitions#502

Merged
codebender828 merged 2 commits intochakra-ui:developfromt-buss:patch-1
Dec 22, 2021

Conversation

@t-buss
Copy link
Contributor

@t-busst-buss commentedDec 20, 2021•
edited
Loading

Description

We notices that the type definitions do not include CGridItem, which leads to false error messages in the IDE although everything works when run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-botbot commentedDec 20, 2021•
edited
Loading

🦋 Changeset detected

Latest commit:b783840

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@chakra-ui/vuePatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercelbot commentedDec 20, 2021•
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect:https://vercel.com/chakra-ui/chakra-ui-vue/2vf5nACEFtYgYwKzm9t2DrbdJNGJ
✅ Preview:https://chakra-ui-vue-git-fork-t-buss-patch-1-chakra-ui.vercel.app

@codesandbox-ci
Copy link

codesandbox-cibot commentedDec 20, 2021•
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commitb783840:

SandboxSource
Chakra UI Vue (0.X) Starter TemplateConfiguration
chakra-ui-nuxt-demoConfiguration

@t-busst-buss changed the titleInclude CGridItem in type definitionsFix: Include CGridItem in type definitionsDec 21, 2021
Copy link
Collaborator

@codebender828codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@t-buss This is great!

@codebender828codebender828 self-requested a reviewDecember 22, 2021 16:36
codebender828
codebender828 previously approved these changesDec 22, 2021
@codebender828codebender828 changed the titleFix: Include CGridItem in type definitionsfix: Include CGridItem in type definitionsDec 22, 2021
@codebender828codebender828 merged commit473cb94 intochakra-ui:developDec 22, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@codebender828codebender828codebender828 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-buss@codebender828
[8]ページ先頭
©2009-2025 Movatter.jp