- Notifications
You must be signed in to change notification settings - Fork273
Added Required Python Version#152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Added python_requires to specify the required python version for the library.
sigmavirus24 commentedApr 21, 2021
I believe this library supports Python 3.5+ not 3.3+ |
Nirzak commentedApr 21, 2021
Ok updated it. There are classifiers for python 3.3 and 3.4 that's why I thought it would be 3.3+ |
Nirzak commentedApr 21, 2021
Should I also remove the classifiers for python 3.3 and 3.4? |
jdufresne commentedAug 26, 2021
IMO, yes. The classifiers and |
iceman201 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
'Programming Language :: Python :: 3.3', 'Programming Language :: Python :: 3.4',would be good to remove
Uh oh!
There was an error while loading.Please reload this page.
| include_package_data=True, | ||
| zip_safe=False, | ||
| license='MPL-2.0', | ||
| python_requires=">=3.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would be preferable to introduce this in declarative config. i.e.:
# setup.cfg[options]python_requires = >=3.5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would be good to do setup-py-upgrade in another pr I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, perhaps. My preference is to introduce changes in the preferred location rather than to cling to old conventions, but I also see the value in keeping it all consistent and to move everything at once.
jaraco commentedOct 18, 2021
This PR fixes#174. |
Added python_requires to specify the required python version for the library.