Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/cephPublic

doc/rados: Fix minor issues and improvements in health-checks.rst#66662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bluikko wants to merge1 commit intoceph:main
base:main
Choose a base branch
Loading
frombluikko:wip-doc-rados-ops-health-checks-fixes

Conversation

@bluikko
Copy link
Contributor

@bluikkobluikko commentedDec 17, 2025
edited
Loading

Use title case consistently in section titles.

Wrap long lines over 80 characters.

Use "Ceph Manager" instead of "ceph-mgr".
Use "Ceph Monitor" or "Monitor" consistently instead of "monitor".

Use :confval: instead of simple inline literal text for config values.

Linkify, adding a label in the destination if necessary:

  • Muting health checks
  • Mon election strategy

Fix a typo.

Use RST*italic* instead of_rendered underscores_.

Use a privileged prompt for CLI command examples requiring privileges.

Use path including fsid to mon data consistently.

Part 1 of x.

Contribution Guidelines

  • To sign and title your commits, please refer toSubmitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer toSubmitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding anx between the brackets:[x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • AffectsDashboard, opened tracker ticket
    • AffectsOrchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@bluikko
Copy link
ContributorAuthor

bluikko commentedDec 17, 2025
edited
Loading

It seems to be a very bad idea to reflow text after making a change in the middle of a paragraph. Massive diffstat, so much change, some say it is maybe the largest amount of change ever.
This file is very long and will not wrap lines like this on follow-up PRs.

Maybe just reflow the whole file in the final PR? Or in a separate PR at the end.

The rendered PR looks OK, this is ready for review.

@bluikkobluikko marked this pull request as ready for reviewDecember 17, 2025 09:55
@bluikkobluikko requested review froma team ascode ownersDecember 17, 2025 09:55
Use title case consistently in section titles.Wrap long lines over 80 characters.Use "Ceph Manager" instead of "ceph-mgr".Use "Ceph Monitor" or "Monitor" consistently instead of "monitor".Use :confval: instead of simple inline literal text for config values.Linkify, adding a label in the destination if necessary:- Muting health checks- Mon election strategyFix a typo.Use RST *italic* instead of _rendered underscores_.Use a privileged prompt for CLI command examples requiring privileges.Use path including fsid to mon data consistently.Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
@bluikkobluikkoforce-pushed thewip-doc-rados-ops-health-checks-fixes branch from01fa60b to7796ad5CompareDecember 18, 2025 03:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@anthonyelevenanthonyelevenanthonyeleven approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bluikko@anthonyeleven

[8]ページ先頭

©2009-2025 Movatter.jp