- Notifications
You must be signed in to change notification settings - Fork6.2k
doc/rados: Fix minor issues and improvements in health-checks.rst#66662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
bluikko commentedDec 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It seems to be a very bad idea to reflow text after making a change in the middle of a paragraph. Massive diffstat, so much change, some say it is maybe the largest amount of change ever. Maybe just reflow the whole file in the final PR? Or in a separate PR at the end. The rendered PR looks OK, this is ready for review. |
Uh oh!
There was an error while loading.Please reload this page.
Use title case consistently in section titles.Wrap long lines over 80 characters.Use "Ceph Manager" instead of "ceph-mgr".Use "Ceph Monitor" or "Monitor" consistently instead of "monitor".Use :confval: instead of simple inline literal text for config values.Linkify, adding a label in the destination if necessary:- Muting health checks- Mon election strategyFix a typo.Use RST *italic* instead of _rendered underscores_.Use a privileged prompt for CLI command examples requiring privileges.Use path including fsid to mon data consistently.Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
01fa60b to7796ad5Compare
Uh oh!
There was an error while loading.Please reload this page.
Use title case consistently in section titles.
Wrap long lines over 80 characters.
Use "Ceph Manager" instead of "ceph-mgr".
Use "Ceph Monitor" or "Monitor" consistently instead of "monitor".
Use :confval: instead of simple inline literal text for config values.
Linkify, adding a label in the destination if necessary:
Fix a typo.
Use RST
*italic*instead of_rendered underscores_.Use a privileged prompt for CLI command examples requiring privileges.
Use path including fsid to mon data consistently.
Part 1 of x.
Contribution Guidelines
To sign and title your commits, please refer toSubmitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer toSubmitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job |Jenkins Job Definitionjenkins test crimson perfJenkins Job |Jenkins Job Definitionjenkins test signedJenkins Job |Jenkins Job Definitionjenkins test make checkJenkins Job |Jenkins Job Definitionjenkins test make check arm64Jenkins Job |Jenkins Job Definitionjenkins test submodulesJenkins Job |Jenkins Job Definitionjenkins test dashboardJenkins Job |Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job |Jenkins Job Definitionjenkins test apiJenkins Job |Jenkins Job Definitionjenkins test docsReadTheDocs |Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs |Jenkins Jobs Definitionjenkins test windowsJenkins Job |Jenkins Job Definitionjenkins test rook e2eJenkins Job |Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.