- Notifications
You must be signed in to change notification settings - Fork6.2k
mgr: change cleanup and scanning cephfs connection logs to be less noisy#66640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Omid Yoosefi <omidyoosefi@ibm.com>
omidyoosefi commentedDec 17, 2025
jenkins test api |
batrick left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please create atracker issue so that this issue can be tracked for backporting.
Then,please annotate the commit which fixes/resolves a Ceph tracker issue with:
Fixes: http://tracker.ceph.com/issues/...
This is essential when examining the history of the repository (this commit fixes what) and helps merge scripts identify issues that have been resolved by a merge. Seethis article on GitHub on how to amend commits and update your pull request.
| defcleanup_connections(self)->None: | ||
| withself.lock: | ||
| logger.info("scanning for idle connections..") | ||
| logger.debug("scanning for idle connections..") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| logger.debug("scanning for idle connections..") | |
| logger.debug("scanning for idle connections...") |
| idle_conns.append((fs_name,connection)) | ||
| logger.info(f'cleaning up connections:{idle_conns}') | ||
| foridle_conninidle_conns: | ||
| logger.info(f'cleaning up connections:{idle_conn}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| logger.info(f'cleaning upconnections:{idle_conn}') | |
| logger.info(f'cleaning upconnection:{idle_conn}') |
Uh oh!
There was an error while loading.Please reload this page.
Intro
infoChange
scanninglog to debugcleaning uplog to the for loop so it only logs when it's actually doing somethingChecklist
Show available Jenkins commands
jenkins test classic perfJenkins Job |Jenkins Job Definitionjenkins test crimson perfJenkins Job |Jenkins Job Definitionjenkins test signedJenkins Job |Jenkins Job Definitionjenkins test make checkJenkins Job |Jenkins Job Definitionjenkins test make check arm64Jenkins Job |Jenkins Job Definitionjenkins test submodulesJenkins Job |Jenkins Job Definitionjenkins test dashboardJenkins Job |Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job |Jenkins Job Definitionjenkins test apiJenkins Job |Jenkins Job Definitionjenkins test docsReadTheDocs |Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs |Jenkins Jobs Definitionjenkins test windowsJenkins Job |Jenkins Job Definitionjenkins test rook e2eJenkins Job |Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.