This repository was archived by the owner on Dec 23, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork196
add ability to attach custom headers to traces#2105
Open
kirbyquerby wants to merge3 commits intocensus-instrumentation:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This change adds the ability to attach custom gRPC metadata headers to trace requests.The Go library has a WithHeaders() option with this functionality:https://pkg.go.dev/contrib.go.opencensus.io/exporter/ocagent#WithHeaders
Author
kirbyquerby commentedAug 19, 2022
/cc@odeke-em |
Member
odeke-em commentedAug 20, 2022
Thank you for the PR@kirbyquerby! Kindly pinging@punya@mackenziestarr@jsuereth to help with a review, merge and later release. Thank you all! |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the ability to attach custom gRPC metadata headers to trace requests.
The Go library has a WithHeaders() option with this functionality:https://pkg.go.dev/contrib.go.opencensus.io/exporter/ocagent#WithHeaders