Commit14d5dcb

committed

explain what the open questions are, and add a Miri test for that

1 parent07d3009 commit14d5dcbCopy full SHA for 14d5dcb

File tree

-0

lines changed

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -452,6 +452,11 @@ mod mut_ptr;`
`452`	`452`	`///`
`453`	`453`	/// This is almost the same as calling [`ptr::read`] and discarding
`454`	`454`	`/// the result, but has the following advantages:`
	`455`	`+// FIXME: say something more useful than "almost the same"?`
	`456`	+// There are open questions here: `read` requires the value to be fully valid, e.g. if `T` is a
	`457`	+// `bool` it must be 0 or 1, if it is a reference then it must be dereferenceable. `drop_in_place`
	`458`	+// only requires that `*to_drop` be "valid for dropping" and we have not defined what that means. In
	`459`	`+// Miri it currently (May 2024) requires nothing at all for types without drop glue.`
`455`	`460`	`///`
`456`	`461`	/// * It is required to use `drop_in_place` to drop unsized types like
`457`	`462`	`/// trait objects, because they can't be read out onto the stack and`

Comments

(0)