Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.9k
Reproduce issue#9475 Create test_json_serializer_mem_leak.py test#9817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
codecovbot commentedJul 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@## main #9817 +/- ##======================================= Coverage 78.62% 78.62% ======================================= Files 153 153 Lines 19199 19199 Branches 2547 2547 ======================================= Hits 15095 15095 Misses 3811 3811 Partials 293 293
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds a new integration test to reproduce and detect the JSON serialization memory leak described in issue#9475. It measures memory usage for nested Celery chains/groups using both JSON and pickle serializers and asserts against a configurable threshold.
- Introduce
test_json_serializer_mem_leak.pyundert/integrationto compare memory footprints of JSON vs pickle. - Use
psutil(if available) ortracemallocto track RSS or Python heap allocations. - Fail the test if JSON serialization uses more memory than pickle beyond the specified threshold.
Comments suppressed due to low confidence (1)
t/integration/test_json_serializer_mem_leak.py:103
- Reference to
create_job1_taskwill raise a NameError since it's neither defined nor imported. Add a local definition of this task factory or import it from the module where it's implemented.
job1 = create_job1_task(app)Uh oh!
There was an error while loading.Please reload this page.
| } | ||
| def test_json_serialization_memory_leak(): |
CopilotAIJul 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[nitpick] Instead of using rawprint calls for reporting, consider leveraging the test framework's assertion messages or a logging facility to produce structured, machine-readable output.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
to reproduce#9475