Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Apply task upon eager retry#8367

Draft
andrewdieken wants to merge3 commits intocelery:main
base:main
Choose a base branch
Loading
fromandrewdieken:fix-retry-eager-logic

Conversation

andrewdieken
Copy link

This PR will be merged into branchmain.

Description

This PR updates theretry methods eager logic of theTask class ensuringapply is called on the createdSignature object.

Fixes#8056

@andrewdieken
Copy link
Author

@auvipy this change broke quite a few tests within thetest_task_retries test class 😠 started to track down the issue(s) but ran out of time. Will continue to work through the failures but wanted to get the PR opened so you could get 👀 on it

@auvipy
Copy link
Member

it seems you didn't pick all the needed parts here. you can check the old pr

@djanowski
Copy link

Hi! Any updates here? I can't test the retry logic without this change. Thank you!

@NusnusNusnusforce-pushed thefix-retry-eager-logic branch from5c2fa70 todce7f0aCompareMay 2, 2024 21:05
@andrewdieken
Copy link
Author

Hi! Any updates here? I can't test the retry logic without this change. Thank you!

Unfortunately, I haven't put any more time into this. I appreciate and welcome any support on this PR!

@NusnusNusnus marked this pull request as draftJune 6, 2024 15:21
@CelestialStreamer
Copy link

CelestialStreamer commentedSep 14, 2024
edited
Loading

I tried changing it to this w/o success. My tasks do get called multiple times in my tests, that part is fixed, but the return value isn't getting through. Not sure what I'm missing:

        ret = Retry(exc=exc, when=eta or countdown, is_eager=is_eager, sig=S)        if is_eager:            # if task was executed eagerly using apply(),            # then the retry must also be executed eagerly in apply method            retry_ret = S.apply().get()            if throw:                raise ret            return retry_ret

Tried with justS.apply() andreturn ret vsreturn retry_ret with no success. Sorry, I'm just not familiar with what is supposed to happen here, but I thought I'd poke around to see if I could get it work.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Django 2.2 + Celery 5.2.7 unit testing does not Retrying the task
5 participants
@andrewdieken@auvipy@djanowski@CelestialStreamer@Nusnus

[8]ページ先頭

©2009-2025 Movatter.jp