- Notifications
You must be signed in to change notification settings - Fork4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Apply task upon eager retry#8367
base:main
Are you sure you want to change the base?
Conversation
@auvipy this change broke quite a few tests within the |
it seems you didn't pick all the needed parts here. you can check the old pr |
djanowski commentedMar 21, 2024
Hi! Any updates here? I can't test the retry logic without this change. Thank you! |
Unfortunately, I haven't put any more time into this. I appreciate and welcome any support on this PR! |
I tried changing it to this w/o success. My tasks do get called multiple times in my tests, that part is fixed, but the return value isn't getting through. Not sure what I'm missing:
Tried with just |
This PR will be merged into branch
main
.Description
This PR updates the
retry
methods eager logic of theTask
class ensuringapply
is called on the createdSignature
object.Fixes#8056