- Notifications
You must be signed in to change notification settings - Fork36
Implement ExternalValue#96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This is initial implementation. It's not well tested.Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian commentedOct 15, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
After reading through spec a little. Abstract values are opaque and their members can't be accessed. The added It will default to non-opaque mode if type implements Also, the drop logic I used is something I already tested in another crate with Miri, so itshould work. Oh, and CEL is designed for use with protobuf, so what#81 is doing might be a better fit. I'll probably fork off with these changes into a different crate if I get really invested in this because my use case calls for a lot of things that go against or aren't aligned with the spec. |
This is initial implementation that adds support forabstract-types.
Not well tested (or at all).
I'm mostly creating this to provide an exhaustive example that compiles.
Couldclose#93 with some additional work, or be used for top level
Value
trait mentioned in#76.