- Notifications
You must be signed in to change notification settings - Fork36
Proto types#116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
JonasHedEng wants to merge3 commits intocel-rust:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Proto types#116
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
These are vendored fromhttps://github.com/google/cel-spec,proto/cel/expr/ at ed066e332b7acc3dbf68e65e0001061539d25e83.The other files only contain messages for interacting with a CELinterpreter, but don't represent ASTs.
This adds the cel_interpreter::proto mod, exposing the cel.expr protobuftypes, as well as the necessary plumbing to generate the typedefinitions at compile time.The outcome can be best explored by invoking `cargo doc` with the`proto` feature enabled, and starting at the`cel_interpreter::proto::[Parsed]Expr` struct.
I think you might be interested inthis PR that reuses the original antlr grammar and creates an AST aligned with the one of the go code (and java & C++). |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of#81 . I made an attempt at some initial conversion to/from proto expressions. Does the expression IDs exist somewhere or are they computable as of now? I skipped it for now. I'll try to pick it up at a later point, but please feel free to pick it up from here!
I think what "should" be implemented is actually to/from
ParsedExprandCheckedExprbut sinceExpris the underlying type, I went for that to begin with.