Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added minimal WPF designer support#1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
amaitland merged 1 commit intocefsharp:masterfrommerceyz:pr22
Mar 20, 2017
Merged

Added minimal WPF designer support#1989

amaitland merged 1 commit intocefsharp:masterfrommerceyz:pr22
Mar 20, 2017

Conversation

@merceyz
Copy link
Member

@merceyzmerceyz commentedMar 17, 2017
edited
Loading

  • Fixed WPF designer support

protectedvirtualboolCreateOffscreenBrowser(Sizesize)
{
if(browserCreated||System.ComponentModel.DesignerProperties.GetIsInDesignMode(this)||size.IsEmpty||size.Equals(newSize(0,0)))
if(browserCreated||size.IsEmpty||size.Equals(newSize(0,0)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is there a reason we're no longer checking design mode here?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

CreateOffscreenBrowser gets called fromOnActualSizeChanged which isn't registered when in design mode.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense 👍

@amaitlandamaitland added this to the57.0.0 milestoneMar 20, 2017
@amaitland
Copy link
Member

All looks pretty straight forward 👍

@amaitlandamaitland merged commita35a030 intocefsharp:masterMar 20, 2017
@amaitlandamaitland added enhancement wpfWPF Implementation labelsMar 29, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@amaitlandamaitlandamaitland left review comments

Assignees

No one assigned

Labels

enhancementwpfWPF Implementation

Projects

None yet

Milestone

57.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@merceyz@amaitland

[8]ページ先頭

©2009-2025 Movatter.jp