Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Enable readline on FreeBSD#88

Open
yurivict wants to merge2 commits intoccxvii:master
base:master
Choose a base branch
Loading
fromyurivict:master

Conversation

yurivict
Copy link

CFLAGS addition is needed because thereadline.h header is located under prefix, usually/usr/local.

@ccxvii
Copy link
Owner

Then why are you setting CFLAGS += -I$(prefix)? That seems wrong. The 'prefix' is where you're building to install mujs; that has nothing to do with where we can find readline.

@yurivict
Copy link
Author

yurivict commentedFeb 26, 2019
edited
Loading

On FreeBSD all packages are installed into one location, usually withPREFIX=/usr/local.readline is also a package installed there.

@yurivict
Copy link
Author

yurivict commentedFeb 27, 2019
edited
Loading

Practically speaking, there is no need to separatereadline location andmujs install prefix, because virtually all other software doesn't, and on BSDreadline is a package and is installed into the package prefix, which might be different from linux. I maintain a lot of packages on FreeBSD, that's how I know.

@gardhr
Copy link
Contributor

But why would you even want to build them together like that to begin with? Doesn't make much sense at all to do that. Just compile the two libraries separately and then link the object files in the final step. Simple enough anyway.

@yurivict
Copy link
Author

But why would you even want to build them together like that to begin with

They aren't built together. They each are its own port.

@yurivict
Copy link
Author

yurivict commentedJun 7, 2019
edited
Loading

On FreeBSDreadline is available from thereadline package, which is always installed into$(PREFIX), same as themujs package.

The 'prefix' is where you're building to install mujs; that has nothing to do with where we can find readline.

It is always the same location on BSDs. According to GNU standards,$(PREFIX) is where the program is installed and general dependencies are found. Unfortunately, they didn't define a special dependency package path variable.

@yurivict
Copy link
Author

@ccxvii Could you please merge this PR? It allows FreeBSD users to use readline with MuJS, which is otherwise not found.

$prefix is both a location where the project is installed, and where to look for outside dependencies installed from packages.

$ ldd /usr/local/bin/mujs/usr/local/bin/mujs:libreadline.so.8 => /usr/local/lib/libreadline.so.8 (0x8002c3000)libm.so.5 => /lib/libm.so.5 (0x800319000)libc.so.7 => /lib/libc.so.7 (0x80034a000)libncursesw.so.8 => /lib/libncursesw.so.8 (0x800740000)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@yurivict@ccxvii@gardhr

[8]ページ先頭

©2009-2025 Movatter.jp