Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: Theme & ThemeOptions#232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@illusionalsagacity
Copy link
Contributor

@illusionalsagacityillusionalsagacity commentedFeb 28, 2025•
edited
Loading

  • Makes the type naming more consistent between Theme and ThemeOptions
  • Re-order types to be defined in the same order in each module
  • Fixes the breakpoints function types on the theme
  • Removes the now unnecessary runtime overhead of ThemeHelpers.addBreakpoint
  • Add ThemeHelpers.addBreakpointDown function
  • Add ExampleTheme.res file to the repo

resolves#219

fhammerschmidt reacted with hooray emoji
@fhammerschmidt
Copy link
Member

What's the state of this?

illusionalsagacity reacted with rocket emoji

@illusionalsagacity
Copy link
ContributorAuthor

What's the state of this?

Hey, I want to do another once-over to make sure I made the two things consistent and to put an example file in as well to check against the typescript types.

@illusionalsagacityillusionalsagacity changed the titlerefactor(WIP): Theme & ThemeOptionsrefactor: Theme & ThemeOptionsMar 5, 2025
@illusionalsagacityillusionalsagacity marked this pull request as ready for reviewMarch 5, 2025 06:21
- Makes the naming more consistent between the two (needs another check)- Re-order types to be defined in the same order in each module- Fixes the breakpoints function types on the theme- Removes the now unnecessary runtime overhead of ThemeHelpers.addBreakpoint- Add ThemeHelpers.addBreakpointDown function- Add ExampleTheme.res file to the repo
Copy link
Member

@fhammerschmidtfhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Really nice work.

@fhammerschmidtfhammerschmidt merged commit1f6c080 intocca-io:masterMar 10, 2025
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fhammerschmidtfhammerschmidtfhammerschmidt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Theme type is missing the shadows and typography properties

2 participants

@illusionalsagacity@fhammerschmidt
[8]ページ先頭
©2009-2025 Movatter.jp