Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: fix duplicate CI workflow runs on pull requests#260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hsluoyz merged 2 commits intomasterfromcopilot/fix-ci-duplicated-checks
Nov 5, 2025

Conversation

Copy link
Contributor

CopilotAI commentedNov 5, 2025•
edited
Loading

GitHub Actions workflows were running twice on PRs: once for thepush event to the PR branch and once for thepull_request event, causing duplicate checks like "CI / macOS Latest (push)" and "CI / macOS Latest (pull_request)".

Changes

Updated workflow triggers in 4 files to run onpush only for the master branch:

  • .github/workflows/ci.yml
  • .github/workflows/python_binding.yml
  • .github/workflows/memcheck.yml
  • .github/workflows/benchmark.yml

Before:

on:[push, pull_request]

After:

on:push:branches:      -masterpull_request:

PRs now trigger workflows once viapull_request event. Direct pushes to master still trigger viapush event.

Original prompt

This section details on the original issue you should resolve

<issue_title>[bug] needs to fix CI for strange duplicated checks in PR</issue_title>
<issue_description>The following duplicated CI checks ran in this open PR:#258

[CI / macOS Latest (pull_request)](https://github.com/casbin/casbin-cpp/actions/runs/19098521569/job/54571609532?pr=258)CI / macOS Latest (pull_request)Failing after 21s[CI / macOS Latest (push)](https://github.com/casbin/casbin-cpp/actions/runs/19098520831/job/54571609184?pr=258)CI / macOS Latest (push)Failing after 18s[Python Bindings Test / build (macos-latest, 3.8) (pull_request)](https://github.com/casbin/casbin-cpp/actions/runs/19098521581/job/54571609060?pr=258)Python Bindings Test / build (macos-latest, 3.8) (pull_request)Failing after 1m[Python Bindings Test / build (macos-latest, 3.8) (push)](https://github.com/casbin/casbin-cpp/actions/runs/19098520807/job/54571608791?pr=258)Python Bindings Test / build (macos-latest, 3.8) (push)Failing after 1m[Python Bindings Test / build (macos-latest, 3.10) (pull_request)](https://github.com/casbin/casbin-cpp/actions/runs/19098521581/job/54571609067?pr=258)Python Bindings Test / build (macos-latest, 3.10) (pull_request)Failing after 50s[Python Bindings Test / build (macos-latest, 3.10) (push)](https://github.com/casbin/casbin-cpp/actions/runs/19098520807/job/54571608773?pr=258)Python Bindings Test / build (macos-latest, 3.10) (push)Failing after 37s

I think for an open state PR, it should not run "XXX (push)" checks, right? It should run for the git push after PR merge?
Need to fix the CI.</issue_description>

Comments on the Issue (you are@copilot in this section)

✨ Let Copilot coding agentset things up for you — coding agent works faster and does higher quality work when set up for your repo.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let usrecheck it.

@hsluoyzhsluoyz marked this pull request as ready for reviewNovember 5, 2025 11:39
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
CopilotAI changed the title[WIP] Fix CI for duplicated checks in PRFix duplicate CI workflow runs on pull requestsNov 5, 2025
CopilotAI requested a review fromhsluoyzNovember 5, 2025 11:45
Copilot finished work on behalf ofhsluoyzNovember 5, 2025 11:45
@hsluoyzhsluoyz changed the titleFix duplicate CI workflow runs on pull requestsfeat: fix duplicate CI workflow runs on pull requestsNov 5, 2025
@hsluoyzhsluoyz merged commit3c8c9d6 intomasterNov 5, 2025
9 of 14 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.63.0 🎉

The release is available onGitHub release

Yoursemantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hsluoyzhsluoyzAwaiting requested review from hsluoyz

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] needs to fix CI for strange duplicated checks in PR

3 participants

@CLAassistant@hsluoyz
[8]ページ先頭
©2009-2025 Movatter.jp