- Notifications
You must be signed in to change notification settings - Fork283
Fix Windows platform implementation ofsessions command#285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Acters wants to merge2 commits intocalebstewart:masterChoose a base branch fromActers:master
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This fixes the Windows implementation of enumerating a list of users. Also, added extra type checks for edge cases to prevent confusing errors, and will now raise a ModuleFailed error incase users variable is not a dict or list of users.
Added "sessions" command fix to CHANGELOG.md
sessions commandSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This fixes the Windows implementation of enumerating a list of users.
Also, added extra type checks for edge cases to prevent confusing errors, and will now raise a ModuleFailed error incase users variable is not a dict or list of users.
Major Changes Implemented:
users = users[0]as it caused a type error and it would only allow the very first user in list to display when using the sessions command. This is commented because a future feature can allow picking which user in list to grab info from, instead of all the sessions.usersvariable is neither a dict or list, then it will raise a ModuleFailed error.Pre-Merge Tasks
python-blackisortflake8on repo, and fixed any new problems w/ modified filespytesttest cases[Unreleased])