- Notifications
You must be signed in to change notification settings - Fork283
Added module reloading API and CLI interface#243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
calebstewart wants to merge2 commits intomasterChoose a base branch fromfeature/241/support-reloading-modules
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR adds the ability to reload pwncat modules at runtime. This is facilitated through the addition of a new flag for the
Manager.load_modulesmethod, which now takes aforcekeyword argument, which forces reloading of previously loaded modules. Further, there is now a newManager.reload_modulemethod which accepts either a module instance or a module name to be reloaded specifically. Bothload_modulesandreload_modulemethods will also attempt to fix the current module context if a module is being reloaded, and reset any module configurations, which could fail if the module arguments have changed during reload. If a module-specific configuration fails to apply after reloading the module (likely because the module arguments changed on disk), a warning is printed and that configuration is lost.Lastly, this PR adds new arguments to two pwncat commands:
loadandrun. First, theloadcommand now as either--force/-for--reload/-rarguments. These are synonyms which force a reload of modules during loading (through the force argument ofManager.load_modules). Second, theruncommand now accepts a--reload/-rargument which forces the selected module to be reloaded viaManager.reload_moduleprior to execution, which should be useful when debugging a new module (or a misbehaving old module).Fixes#241.
Please note any
noqa:comments needed to appease flake8.Major Changes Implemented:
forceargument toManager.load_modulesto enable reloading modules.Manager.reload_modulemethod to reload a specific module.--force/-fand--reload/-rarguments to theloadcommand (#241).--reload/-rargument to theruncommand to reload modules prior to executing.Pre-Merge Tasks
python-blackisortflake8on repo, and fixed any new problems w/ modified filespytesttest cases[Unreleased])For issues with pre-merge tasks, see CONTRIBUTING.md