- Notifications
You must be signed in to change notification settings - Fork283
Moved XDG config loading to entrypoint#242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
calebstewart wants to merge2 commits intomasterChoose a base branch fromfix/239/default-config-path
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Removed loading configuration from XDG directories out of the Managerconstructor, and modified logic to comply with the XDG Base Directoriesspecification. This should now obey XDG_CONFIG_HOME, XDG_CONFIG_DIRS,XDG_DATA_HOME and XDG_DATA_DIRS with correct precedence.If no configuration is passed to the `Manager` constructor, it will nolonger load any configuration by default.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removed loading configuration from XDG directories out of the Manager
constructor and into the main entrypoint, and modified logic to comply
with the XDG Base Directories specification. This should now obey
XDG_CONFIG_HOME, XDG_CONFIG_DIRS, XDG_DATA_HOME and
XDG_DATA_DIRS with correct precedence. Modules from any data
directory will also be loaded (e.g.
/etc/pwncat/modulesor~/.local/share/pwncat/modules).If no configuration is passed to the
Managerconstructor, it will nolonger load any configuration by default (the built-in modules will still be
loaded, though).
I also had to update the unit test for custom configurations, since the
Managerclass no longer loads from XDG directories.Fixes#239
Please note any
noqa:comments needed to appease flake8.Major Changes Implemented:
Managerclass.Pre-Merge Tasks
python-blackisortflake8on repo, and fixed any new problems w/ modified filespytesttest cases[Unreleased])For issues with pre-merge tasks, see CONTRIBUTING.md