Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Moved XDG config loading to entrypoint#242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
calebstewart wants to merge2 commits intomaster
base:master
Choose a base branch
Loading
fromfix/239/default-config-path

Conversation

@calebstewart
Copy link
Owner

Description of Changes

Removed loading configuration from XDG directories out of the Manager
constructor and into the main entrypoint, and modified logic to comply
with the XDG Base Directories specification. This should now obey
XDG_CONFIG_HOME, XDG_CONFIG_DIRS, XDG_DATA_HOME and
XDG_DATA_DIRS with correct precedence. Modules from any data
directory will also be loaded (e.g./etc/pwncat/modules or
~/.local/share/pwncat/modules).

If no configuration is passed to theManager constructor, it will no
longer load any configuration by default (the built-in modules will still be
loaded, though).

I also had to update the unit test for custom configurations, since the
Manager class no longer loads from XDG directories.

Fixes#239

Please note anynoqa: comments needed to appease flake8.

Major Changes Implemented:

  • Removed default configuration loading fromManager class.
  • Added XDG-compliant configuration and module loading to the main entrypoint.

Pre-Merge Tasks

  • Formatted all modified files w/python-black
  • Sorted imports for modified files w/isort
  • Ranflake8 on repo, and fixed any new problems w/ modified files
  • Ranpytest test cases
  • Added brief summary of updates to CHANGELOG (under[Unreleased])

For issues with pre-merge tasks, see CONTRIBUTING.md

Removed loading configuration from XDG directories out of the Managerconstructor, and modified logic to comply with the XDG Base Directoriesspecification. This should now obey XDG_CONFIG_HOME, XDG_CONFIG_DIRS,XDG_DATA_HOME and XDG_DATA_DIRS with correct precedence.If no configuration is passed to the `Manager` constructor, it will nolonger load any configuration by default.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BlankXDG_CONFIG_HOME not handled correctly

2 participants

@calebstewart

[8]ページ先頭

©2009-2025 Movatter.jp