- Notifications
You must be signed in to change notification settings - Fork11.2k
chore: Fix circular dependency in tanstack-table.d.ts#25411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore: Fix circular dependency in tanstack-table.d.ts#25411
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No issues found across 3 files
keithwillcode commentedNov 26, 2025
@emrysal like the changes. Just having build problems |
vercelbot commentedNov 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for GitHub. |
github-actionsbot commentedNov 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
E2E results are ready! |
1ab4b9d intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Summary by cubic
Fixed a circular dependency in table typings by moving shared filter types to packages/types/data-table.d.ts and updating tanstack-table.d.ts to import from it. This stabilizes type augmentation and removes build issues.
Written for commit1fde096. Summary will update automatically on new commits.