Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: Fix circular dependency in tanstack-table.d.ts#25411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@emrysal
Copy link
Contributor

@emrysalemrysal commentedNov 26, 2025
edited by cubic-dev-aibot
Loading

Summary by cubic

Fixed a circular dependency in table typings by moving shared filter types to packages/types/data-table.d.ts and updating tanstack-table.d.ts to import from it. This stabilizes type augmentation and removes build issues.

  • Refactors
    • Centralized ColumnFilterMeta, FilterableColumn, and TextFilterOperator in packages/types/data-table.d.ts; introduced a FilterType union.
    • Updated tanstack-table.d.ts to import ColumnFilterMeta from "./data-table" and simplified ColumnMeta (removed generics).
    • Cleaned up features/data-table/lib/types.ts to re-export ColumnFilterMeta, FilterableColumn, and TextFilterOperator, switch enum to const and generics to FilterType; updated filter components, insights-view, server handlers, and tests to use Extract<FilterType, "...">.

Written for commit1fde096. Summary will update automatically on new commits.

@graphite-appgraphite-appbot requested a review froma teamNovember 26, 2025 13:23
@keithwillcodekeithwillcode added corearea: core, team members only foundation labelsNov 26, 2025
Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 3 files

keithwillcode
keithwillcode previously approved these changesNov 26, 2025
@keithwillcode
Copy link
Contributor

@emrysal like the changes. Just having build problems

@vercel
Copy link

vercelbot commentedNov 26, 2025
edited
Loading

The latest updates on your projects. Learn more aboutVercel for GitHub.

2 Skipped Deployments
ProjectDeploymentPreviewCommentsUpdated (UTC)
calIgnoredIgnoredNov 26, 2025 4:29pm
cal-euIgnoredIgnoredNov 26, 2025 4:29pm

@github-actions
Copy link
Contributor

github-actionsbot commentedNov 26, 2025
edited
Loading

E2E results are ready!

@keithwillcodekeithwillcode merged commit1ab4b9d intomainNov 26, 2025
40 of 41 checks passed
@keithwillcodekeithwillcode deleted the chore/fix-circular-dependency-tanstack-table.d.ts branchNovember 26, 2025 17:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cubic-dev-aicubic-dev-ai[bot]cubic-dev-ai[bot] left review comments

@keithwillcodekeithwillcodekeithwillcode approved these changes

Assignees

No one assigned

Labels

corearea: core, team members onlyfoundationready-for-e2esize/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emrysal@keithwillcode

[8]ページ先頭

©2009-2025 Movatter.jp