NotificationsYou must be signed in to change notification settings
Fork11.2k
Star39k

test: Improve create teams handler tests#25213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sean-brydon merged 2 commits intomainfromtests/createTeams-handler-test

Nov 17, 2025

Merged

test: Improve create teams handler tests#25213

sean-brydon merged 2 commits intomainfromtests/createTeams-handler-test

Nov 17, 2025

Conversation

Copy link

Member

sean-brydon commentedNov 17, 2025•
edited by cubic-dev-aibot
Loading

I am refactoring create teams handler to a service in another PR - thought we should improve the test in the mean time.

Summary by cubic

Expand and restructure tests for createTeamsHandler to cover auth, org/slug validation, team creation and migration, redirects, credits, invites, and subscriptions. This improves reliability ahead of the service refactor.

Refactors
- Rewrote tests into scenario-based suites for Authorization, Organization Validation, Slug Validation, Team Creation/Migration, Redirects, and Edge Cases.
- Added helpers (createTestProfile, flexible createScenario/createTestMembership) and organization/profile support to model slug collisions.
- Assert TRPCError codes/messages and redirect records; cover platform orgs, unpublished/non-existent teams, and empty names.
- Mocked Stripe subscription cancel and inviteMembersWithNoInviterPermissionCheck; verified credit transfer and owner memberships.

^{Written for commit8c216c6. Summary will update automatically on new commits.}

sean-brydon added2 commits

November 17, 2025 10:20

Replace old test file

3a9196c

Fix files

8c216c6

pull-request-sizebot added the size/XXL label

Nov 17, 2025

graphite-appbot requested a review froma team

November 17, 2025 10:24

keithwillcode added consumer corearea: core, team members only labels

Nov 17, 2025

sean-brydon added the ready-for-e2e label

Nov 17, 2025

cubic-dev-aibot reviewed

Nov 17, 2025

View reviewed changes

Copy link

Contributor

cubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.<file name="packages/trpc/server/routers/viewer/organizations/__tests__/createTeams.handler.test.ts"><violation number="1" location="packages/trpc/server/routers/viewer/organizations/__tests__/createTeams.handler.test.ts:189">The new &quot;NoOrganizationError&quot; test still asserts a FORBIDDEN/not_authorized response, so it never verifies the missing-organization error path and simply duplicates the previous authorization test.</violation></file>

_{Reply to cubic to teach it or ask questions. Re-run a review with@cubic-dev-ai review this PR}

packages/trpc/server/routers/viewer/organizations/__tests__/createTeams.handler.test.ts

		creationSource:CreationSource.WEBAPP,
		},
		})
		).rejects.toMatchObject({

Copy link

Contributor

cubic-dev-aibotNov 17, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The new "NoOrganizationError" test still asserts a FORBIDDEN/not_authorized response, so it never verifies the missing-organization error path and simply duplicates the previous authorization test.

Prompt for AI agents

Address the following comment on packages/trpc/server/routers/viewer/organizations/__tests__/createTeams.handler.test.ts at line 189:<comment>The new &quot;NoOrganizationError&quot; test still asserts a FORBIDDEN/not_authorized response, so it never verifies the missing-organization error path and simply duplicates the previous authorization test.</comment><file context>@@ -123,354 +139,1120 @@ async function createScenario(options: CreateScenarioOptions = {}) {+            creationSource: CreationSource.WEBAPP,+          },+        })+      ).rejects.toMatchObject({+        code: &quot;FORBIDDEN&quot;,+        message: &quot;not_authorized&quot;,</file context>