- Notifications
You must be signed in to change notification settings - Fork11.2k
feat: v2 api allow switching event type between collective and round robin#25045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: v2 api allow switching event type between collective and round robin#25045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
1 issue found across 4 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="packages/platform/types/event-types/event-types_2024_06_14/inputs/update-event-type.input.ts"><violation number="1" location="packages/platform/types/event-types/event-types_2024_06_14/inputs/update-event-type.input.ts:491">Adding the enum validator without @IsOptional() makes schedulingType mandatory, so PATCH requests that don’t set it will now fail validation. Please mark the field optional before validating so existing updates keep working.</violation></file>React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.
packages/platform/types/event-types/event-types_2024_06_14/inputs/update-event-type.input.ts OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
vercelbot commentedNov 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No issues found across 1 file
github-actionsbot commentedNov 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
E2E results are ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Reviewed changes from recent commits (found 1 issue).
1 issue found across 3 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="apps/api/v2/src/modules/organizations/event-types/services/input.service.ts"><violation number="1" location="apps/api/v2/src/modules/organizations/event-types/services/input.service.ts:260">Defaulting hosts to [] means updates that omit hosts now clear the existing host list. Please keep hosts undefined so we don’t drop existing hosts inadvertently.</violation></file>React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.
apps/api/v2/src/modules/organizations/event-types/services/input.service.ts OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Reviewed changes from recent commits (found 1 issue).
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="apps/api/v2/src/modules/organizations/event-types/services/input.service.ts"><violation number="1" location="apps/api/v2/src/modules/organizations/event-types/services/input.service.ts:274">Defaulting to `hosts || []` ensured that update payloads without an explicit hosts array cleared the existing hosts, which is required when collective and round-robin setups differ. The new call passes `undefined`, so the update keeps the prior hosts unintentionally and breaks that expectation.(Based on your team's feedback about requiring explicit hosts during event type updates.) [FEEDBACK_USED]</violation></file>React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.
apps/api/v2/src/modules/organizations/event-types/services/input.service.tsShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No issues found across 2 files
8b4f675 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#25034
Summary by cubic
Allow switching a team event type between collective and round robin in the v2 API. Adds strict validation for host handling and blocks switching to managed via update.
New Features
Refactors
Written for commit32c64eb. Summary will update automatically on new commits.