Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: v2 api allow switching event type between collective and round robin#25045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@supalarry
Copy link
Contributor

@supalarrysupalarry commentedNov 10, 2025
edited by cubic-dev-aibot
Loading

Fixes#25034


Summary by cubic

Allow switching a team event type between collective and round robin in the v2 API. Adds strict validation for host handling and blocks switching to managed via update.

  • New Features

    • PATCH /v2/teams/:id/event-types/:eventTypeId supports schedulingType: collective or roundRobin.
    • When switching schedulingType, you must provide hosts or assignAllTeamMembers; otherwise returns 400.
    • Setting schedulingType to managed via update returns 400.
    • OpenAPI updated and e2e tests cover all switch scenarios and host behavior.
  • Refactors

    • Centralized host population for create/update, using the next scheduling type and skipping hosts for managed event types.

Written for commit32c64eb. Summary will update automatically on new commits.

@supalarrysupalarry requested review froma team ascode ownersNovember 10, 2025 14:10
@linear
Copy link

linearbot commentedNov 10, 2025

@github-actionsgithub-actionsbot added apiarea: API, enterprise API, access token, OAuth reactive⚡︎ labelsNov 10, 2025
@keithwillcodekeithwillcode added corearea: core, team members only platformAnything related to our platform plan labelsNov 10, 2025
Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 issue found across 4 files

Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="packages/platform/types/event-types/event-types_2024_06_14/inputs/update-event-type.input.ts"><violation number="1" location="packages/platform/types/event-types/event-types_2024_06_14/inputs/update-event-type.input.ts:491">Adding the enum validator without @IsOptional() makes schedulingType mandatory, so PATCH requests that don’t set it will now fail validation. Please mark the field optional before validating so existing updates keep working.</violation></file>

React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.

@vercel
Copy link

vercelbot commentedNov 10, 2025
edited
Loading

The latest updates on your projects. Learn more aboutVercel for GitHub.

2 Skipped Deployments
ProjectDeploymentPreviewCommentsUpdated (UTC)
calIgnoredIgnoredNov 10, 2025 5:53pm
cal-euIgnoredIgnoredNov 10, 2025 5:53pm

Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 1 file

@github-actions
Copy link
Contributor

github-actionsbot commentedNov 10, 2025
edited
Loading

E2E results are ready!

Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Reviewed changes from recent commits (found 1 issue).

1 issue found across 3 files

Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="apps/api/v2/src/modules/organizations/event-types/services/input.service.ts"><violation number="1" location="apps/api/v2/src/modules/organizations/event-types/services/input.service.ts:260">Defaulting hosts to [] means updates that omit hosts now clear the existing host list. Please keep hosts undefined so we don’t drop existing hosts inadvertently.</violation></file>

React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.

Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Reviewed changes from recent commits (found 1 issue).

1 issue found across 2 files

Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="apps/api/v2/src/modules/organizations/event-types/services/input.service.ts"><violation number="1" location="apps/api/v2/src/modules/organizations/event-types/services/input.service.ts:274">Defaulting to `hosts || []` ensured that update payloads without an explicit hosts array cleared the existing hosts, which is required when collective and round-robin setups differ. The new call passes `undefined`, so the update keeps the prior hosts unintentionally and breaks that expectation.(Based on your team&#39;s feedback about requiring explicit hosts during event type updates.) [FEEDBACK_USED]</violation></file>

React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.

Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 2 files

@supalarrysupalarry merged commit8b4f675 intomainNov 11, 2025
42 checks passed
@supalarrysupalarry deleted the lauris/cal-6725-fix-not-possible-updating-team-event-type branchNovember 11, 2025 08:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cubic-dev-aicubic-dev-ai[bot]cubic-dev-ai[bot] left review comments

@ThyMinimalDevThyMinimalDevThyMinimalDev approved these changes

Assignees

No one assigned

Labels

apiarea: API, enterprise API, access token, OAuthcorearea: core, team members onlyplatformAnything related to our platform planreactive⚡︎ready-for-e2esize/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: sms not triggered when booking

4 participants

@supalarry@ThyMinimalDev@keithwillcode

[8]ページ先頭

©2009-2025 Movatter.jp