Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: Removed asStringOrNull functions#25029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hbjORbj merged 2 commits intomainfromrefactor/remove-asStringOrNull-deprecated
Nov 10, 2025

Conversation

@emrysal
Copy link
Contributor

@emrysalemrysal commentedNov 9, 2025
edited by cubic-dev-aibot
Loading

Summary by cubic

Replaced deprecated asStringOrNull helpers with Zod-based query validation in SSO getServerSideProps. Removed the helpers file to improve type safety and simplify param handling.

  • Refactors
    • Added a Zod schema to parse and validate provider, email, and username from query.
    • Deleted apps/web/lib/asStringOrNull.tsx and migrated usage in the SSO route.
    • Switched prisma to a named import and used req consistently with orgDomainConfig.

Written for commit750b2e9. Summary will update automatically on new commits.

@graphite-appgraphite-appbot requested a review froma teamNovember 9, 2025 23:37
@keithwillcodekeithwillcode added corearea: core, team members only foundation labelsNov 9, 2025
Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 2 files

@github-actions
Copy link
Contributor

github-actionsbot commentedNov 10, 2025
edited
Loading

E2E results are ready!

Copy link
Contributor

@hbjORbjhbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good stuff!

@hbjORbjhbjORbjenabled auto-merge (squash)November 10, 2025 05:23
@vercel
Copy link

vercelbot commentedNov 10, 2025
edited
Loading

The latest updates on your projects. Learn more aboutVercel for GitHub.

2 Skipped Deployments
ProjectDeploymentPreviewCommentsUpdated (UTC)
calIgnoredIgnoredNov 10, 2025 3:48pm
cal-euIgnoredIgnoredNov 10, 2025 3:48pm

@hbjORbjhbjORbj merged commitdb8c794 intomainNov 10, 2025
38 checks passed
@hbjORbjhbjORbj deleted the refactor/remove-asStringOrNull-deprecated branchNovember 10, 2025 16:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cubic-dev-aicubic-dev-ai[bot]cubic-dev-ai[bot] left review comments

@hbjORbjhbjORbjhbjORbj approved these changes

@Udit-takkarUdit-takkarUdit-takkar approved these changes

Assignees

No one assigned

Labels

corearea: core, team members onlyfoundationready-for-e2esize/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emrysal@hbjORbj@Udit-takkar@keithwillcode

[8]ページ先頭

©2009-2025 Movatter.jp