- Notifications
You must be signed in to change notification settings - Fork11.2k
fix: routing-form org redirects when profile slug equals legacy slug#25003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedNov 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="packages/app-store/routing-forms/getEventTypeRedirectUrl.ts"><violation number="1" location="packages/app-store/routing-forms/getEventTypeRedirectUrl.ts:88">Accessing form.user.username will throw when existing form objects omit the new user field. Please guard the access (e.g., with optional chaining) so legacy callers without form.user keep working.</violation></file>React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No issues found across 1 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No issues found across 1 file
| if(usernameInRedirectUrl&&form.nonOrgUsername){ | ||
| constisEventTypeRedirectToOldUser=usernameInRedirectUrl===form.nonOrgUsername; | ||
| consthasSameProfileUsername=form.user?.username===form.nonOrgUsername; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
form.user.username seems like the User table username for the owner of the form. which isn't the profile username. Profile username is what we have in Profile table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we need the correct profile username here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is already the corrected one; we enrich the user with their profile
Uh oh!
There was an error while loading.Please reload this page.
packages/app-store/routing-forms/__tests__/getEventTypeRedirectUrl.test.tsShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
hariombalhara left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Left a comment
Pull request was converted to draft
908e5e0 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
What does this PR do?