Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Polish, fixes, and i18n updates for onboarding#24949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sean-brydon merged 5 commits intomainfromfeat/onboarding-fixes-and-polish
Nov 12, 2025

Conversation

@sean-brydon
Copy link
Member

@sean-brydonsean-brydon commentedNov 5, 2025
edited by cubic-dev-aibot
Loading

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change(video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require adocumentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read thecontributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Summary by cubic

Polished the onboarding experience with a live calendar preview, a team bio field, and improved username handling. Updated i18n strings and added responsive breakpoints for large screens.

  • New Features

    • Added right-column previews: OnboardingBrowserView in org teams and a live weekly OnboardingCalendarBrowserView for personal calendar setup.
    • Introduced team bio in onboarding store and UI.
    • Expanded i18n: team bio, browser view labels, and CSV invite flow.
    • Added Tailwind screens for 3xl and 4xl to improve large-display layouts.
  • Bug Fixes

    • Normalized usernames with slugify on default and change to prevent invalid slugs.
    • Unified disabled/readonly handling for premium vs. standard username fields; respects external disabled prop and org membership.

Written for commit7804fad. Summary will update automatically on new commits.

@github-actions
Copy link
Contributor

github-actionsbot commentedNov 5, 2025
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow theConventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Polish, fixes, and i18n updates for onboarding". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/Available types: - feat: A new feature - fix: A bug fix - docs: Documentation only changes - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc) - refactor: A code change that neither fixes a bug nor adds a feature - perf: A code change that improves performance - test: Adding missing tests or correcting existing tests - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs) - chore: Other changes that don't modify src or test files - revert: Reverts a previous commit

@keithwillcodekeithwillcode added consumer corearea: core, team members only labelsNov 5, 2025
@sean-brydonsean-brydon marked this pull request as ready for reviewNovember 5, 2025 13:19
@graphite-appgraphite-appbot requested review froma teamNovember 5, 2025 13:19
Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

2 issues found across 6 files

Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.<file name="apps/web/public/static/locales/en/common.json"><violation number="1" location="apps/web/public/static/locales/en/common.json:1435">Removing the existing guest video strings leaves Cal Video flows without translations (the UI falls back to raw i18n keys). Please keep those keys until all call sites are updated.</violation><violation number="2" location="apps/web/public/static/locales/en/common.json:1805">Removing the Cal.ai low-credit email strings means our credit warning/limit emails now render the raw translation keys. Please retain these entries (or update the templates) before shipping.</violation></file>

React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.

@sean-brydonsean-brydonforce-pushed thefeat/calendar-welcome-modal-features branch fromdf91a06 to94d1c35CompareNovember 5, 2025 14:03
@sean-brydonsean-brydonforce-pushed thefeat/onboarding-fixes-and-polish branch fromb0ae141 to08d090fCompareNovember 5, 2025 14:03
@vercel
Copy link

vercelbot commentedNov 5, 2025
edited
Loading

The latest updates on your projects. Learn more aboutVercel for GitHub.

2 Skipped Deployments
ProjectDeploymentPreviewCommentsUpdated (UTC)
calIgnoredIgnoredNov 12, 2025 9:01am
cal-euIgnoredIgnoredNov 12, 2025 9:01am

Copy link
Contributor

@Udit-takkarUdit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@sean-brydon you accidentally pushed yarn.lock file

@sean-brydonsean-brydonforce-pushed thefeat/calendar-welcome-modal-features branch from5f108c5 tob4d9f02CompareNovember 7, 2025 07:59
@sean-brydonsean-brydonforce-pushed thefeat/onboarding-fixes-and-polish branch from7a426dd to965247aCompareNovember 7, 2025 07:59
@sean-brydonsean-brydonforce-pushed thefeat/calendar-welcome-modal-features branch fromb4d9f02 toe678cc1CompareNovember 7, 2025 07:59
@sean-brydonsean-brydonforce-pushed thefeat/calendar-welcome-modal-features branch from8a657dd to8c362c6CompareNovember 11, 2025 10:11
@sean-brydonsean-brydonforce-pushed thefeat/onboarding-fixes-and-polish branch fromba080aa tob4ef9dbCompareNovember 11, 2025 10:11
@sean-brydonsean-brydon changed the base branch fromfeat/calendar-welcome-modal-features tographite-base/24949November 11, 2025 10:47
@sean-brydonsean-brydonforce-pushed thefeat/onboarding-fixes-and-polish branch fromb4ef9db to6639101CompareNovember 11, 2025 10:47
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/24949 tomainNovember 11, 2025 10:48
@sean-brydonsean-brydonforce-pushed thefeat/onboarding-fixes-and-polish branch from6639101 to7ff3c31CompareNovember 11, 2025 10:48
@sean-brydonsean-brydonforce-pushed thefeat/onboarding-fixes-and-polish branch from7ff3c31 to0139cbaCompareNovember 11, 2025 13:38
@sean-brydonsean-brydonforce-pushed thefeat/onboarding-fixes-and-polish branch from8dc7e8d to645ea77CompareNovember 11, 2025 14:27
@sean-brydonsean-brydonforce-pushed thefeat/onboarding-fixes-and-polish branch from645ea77 to7804fadCompareNovember 12, 2025 09:01
@sean-brydonsean-brydon merged commite6e6784 intomainNov 12, 2025
105 of 113 checks passed
@sean-brydonGraphite App
Copy link
MemberAuthor

Merge activity

@sean-brydonsean-brydon deleted the feat/onboarding-fixes-and-polish branchNovember 12, 2025 10:07
@github-actions
Copy link
Contributor

E2E results are ready!

Spandan-Mishra pushed a commit to Spandan-Mishra/cal.com that referenced this pull requestNov 16, 2025
## What does this PR do?<!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. -->- Fixes #XXXX (GitHub issue number)- Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)## Visual Demo (For contributors especially)A visual demonstration is strongly recommended, for both the original and new change **(video / image - any one)**.#### Video Demo (if applicable):- Show screen recordings of the issue or feature.- Demonstrate how to reproduce the issue, the behavior before and after the change.#### Image Demo (if applicable):- Add side-by-side screenshots of the original and updated change.- Highlight any significant change(s).## Mandatory Tasks (DO NOT REMOVE)- [ ] I have self-reviewed the code (A decent size PR without self-review might be rejected).- [ ] I have updated the developer docs in /docs if this PR makes changes that would require a [documentation change](https://cal.com/docs). If N/A, write N/A here and check the checkbox.- [ ] I confirm automated tests are in place that prove my fix is effective or that my feature works.## How should this be tested?<!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Write details that help to start the tests -->- Are there environment variables that should be set?- What are the minimal test data to have?- What is expected (happy path) to have (input and output)?- Any other important info that could help to test that PR## Checklist<!-- Remove bullet points below that don't apply to you -->- I haven't read the [contributing guide](https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md)- My code doesn't follow the style guidelines of this project- I haven't commented my code, particularly in hard-to-understand areas- I haven't checked if my changes generate no new warnings<!-- This is an auto-generated description by cubic. -->---## Summary by cubicPolished the onboarding experience with a live calendar preview, a team bio field, and improved username handling. Updated i18n strings and added responsive breakpoints for large screens.- **New Features**  - Added right-column previews: OnboardingBrowserView in org teams and a live weekly OnboardingCalendarBrowserView for personal calendar setup.  - Introduced team bio in onboarding store and UI.  - Expanded i18n: team bio, browser view labels, and CSV invite flow.  - Added Tailwind screens for 3xl and 4xl to improve large-display layouts.- **Bug Fixes**  - Normalized usernames with slugify on default and change to prevent invalid slugs.  - Unified disabled/readonly handling for premium vs. standard username fields; respects external disabled prop and org membership.<sup>Written for commit7804fad. Summary will update automatically on new commits.</sup><!-- End of auto-generated description by cubic. -->
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Udit-takkarUdit-takkarUdit-takkar left review comments

@cubic-dev-aicubic-dev-ai[bot]cubic-dev-ai[bot] left review comments

@eunjae-leeeunjae-leeeunjae-lee approved these changes

@CarinaWolliCarinaWolliAwaiting requested review from CarinaWolli

Assignees

No one assigned

Labels

consumercorearea: core, team members onlyready-for-e2esize/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sean-brydon@eunjae-lee@CarinaWolli@Udit-takkar@keithwillcode

[8]ページ先頭

©2009-2025 Movatter.jp