- Notifications
You must be signed in to change notification settings - Fork11.2k
fix: Polish, fixes, and i18n updates for onboarding#24949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
github-actionsbot commentedNov 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow theConventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
sean-brydon commentedNov 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
2 issues found across 6 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.<file name="apps/web/public/static/locales/en/common.json"><violation number="1" location="apps/web/public/static/locales/en/common.json:1435">Removing the existing guest video strings leaves Cal Video flows without translations (the UI falls back to raw i18n keys). Please keep those keys until all call sites are updated.</violation><violation number="2" location="apps/web/public/static/locales/en/common.json:1805">Removing the Cal.ai low-credit email strings means our credit warning/limit emails now render the raw translation keys. Please retain these entries (or update the templates) before shipping.</violation></file>React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
df91a06 to94d1c35Compareb0ae141 to08d090fComparevercelbot commentedNov 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for GitHub. |
08d090f to82f4a45Compare94d1c35 to4cc977cCompare4cc977c to5f108c5Compare82f4a45 toe2edcedCompare
Udit-takkar left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@sean-brydon you accidentally pushed yarn.lock file
5f108c5 tob4d9f02Compare7a426dd to965247aCompareb4d9f02 toe678cc1Compare8a657dd to8c362c6Compareba080aa tob4ef9dbCompare8c362c6 todc3742dCompareb4ef9db to6639101Compare6639101 to7ff3c31Compare7ff3c31 to0139cbaCompare8dc7e8d to645ea77Compare645ea77 to7804fadComparee6e6784 intomainUh oh!
There was an error while loading.Please reload this page.
sean-brydon commentedNov 12, 2025
Merge activity
|
E2E results are ready! |
## What does this PR do?<!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. -->- Fixes #XXXX (GitHub issue number)- Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)## Visual Demo (For contributors especially)A visual demonstration is strongly recommended, for both the original and new change **(video / image - any one)**.#### Video Demo (if applicable):- Show screen recordings of the issue or feature.- Demonstrate how to reproduce the issue, the behavior before and after the change.#### Image Demo (if applicable):- Add side-by-side screenshots of the original and updated change.- Highlight any significant change(s).## Mandatory Tasks (DO NOT REMOVE)- [ ] I have self-reviewed the code (A decent size PR without self-review might be rejected).- [ ] I have updated the developer docs in /docs if this PR makes changes that would require a [documentation change](https://cal.com/docs). If N/A, write N/A here and check the checkbox.- [ ] I confirm automated tests are in place that prove my fix is effective or that my feature works.## How should this be tested?<!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Write details that help to start the tests -->- Are there environment variables that should be set?- What are the minimal test data to have?- What is expected (happy path) to have (input and output)?- Any other important info that could help to test that PR## Checklist<!-- Remove bullet points below that don't apply to you -->- I haven't read the [contributing guide](https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md)- My code doesn't follow the style guidelines of this project- I haven't commented my code, particularly in hard-to-understand areas- I haven't checked if my changes generate no new warnings<!-- This is an auto-generated description by cubic. -->---## Summary by cubicPolished the onboarding experience with a live calendar preview, a team bio field, and improved username handling. Updated i18n strings and added responsive breakpoints for large screens.- **New Features** - Added right-column previews: OnboardingBrowserView in org teams and a live weekly OnboardingCalendarBrowserView for personal calendar setup. - Introduced team bio in onboarding store and UI. - Expanded i18n: team bio, browser view labels, and CSV invite flow. - Added Tailwind screens for 3xl and 4xl to improve large-display layouts.- **Bug Fixes** - Normalized usernames with slugify on default and change to prevent invalid slugs. - Unified disabled/readonly handling for premium vs. standard username fields; respects external disabled prop and org membership.<sup>Written for commit7804fad. Summary will update automatically on new commits.</sup><!-- End of auto-generated description by cubic. -->

Uh oh!
There was an error while loading.Please reload this page.
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change(video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Summary by cubic
Polished the onboarding experience with a live calendar preview, a team bio field, and improved username handling. Updated i18n strings and added responsive breakpoints for large screens.
New Features
Bug Fixes
Written for commit7804fad. Summary will update automatically on new commits.