Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: configure correct error message for duplicate event type slug#24928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@dhairyashiil
Copy link
Member

@dhairyashiildhairyashiil commentedNov 5, 2025
edited by cubic-dev-aibot
Loading

What does this PR do?

Visual Demo (For contributors especially)

Screen.Recording.2025-11-05.at.5.35.36.AM.mov

Summary by cubic

Shows a clear, localized error when duplicating an event type to a URL that already exists, preventing confusion and failed duplicates. Addresses CAL-6696 and#24924.

  • Bug Fixes
    • Backend returns CONFLICT (instead of BAD_REQUEST) on slug uniqueness violations.
    • Duplicate dialog handles CONFLICT and shows a localized message: “An event type with this URL already exists. Please try a different URL.”
    • Added i18n key duplicate_event_slug_conflict.

Written for commitf067d95. Summary will update automatically on new commits.

@vercel
Copy link

vercelbot commentedNov 5, 2025

@dhairyashiil is attempting to deploy a commit to thecal Team onVercel.

A member of the Team first needs toauthorize it.

@graphite-appgraphite-appbot added the communityCreated by Linear-GitHub Sync labelNov 5, 2025
@github-actionsgithub-actionsbot added the 🐛 bugSomething isn't working labelNov 5, 2025
@github-actions
Copy link
Contributor

github-actionsbot commentedNov 5, 2025
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow theConventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fix/duplicate-event-type-to-existing slug". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/Available types: - feat: A new feature - fix: A bug fix - docs: Documentation only changes - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc) - refactor: A code change that neither fixes a bug nor adds a feature - perf: A code change that improves performance - test: Adding missing tests or correcting existing tests - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs) - chore: Other changes that don't modify src or test files - revert: Reverts a previous commit

@keithwillcodekeithwillcode added the community-internsThe team responsible for reviewing, testing and shipping low/medium community PRs labelNov 5, 2025
@dhairyashiildhairyashiil changed the titlefix/duplicate-event-type-to-existing slugfix: configure correct error message for duplicate event type slugNov 5, 2025
Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 3 files

Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 1 file

Copy link
Contributor

@emrysalemrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Excellent! Quick work man, kudos.

dhairyashiil reacted with laugh emoji
@emrysalemrysalenabled auto-merge (squash)November 5, 2025 00:40
@dhairyashiil
Copy link
MemberAuthor

Excellent! Quick work man, kudos.

My pleasure sir : )

@github-actions
Copy link
Contributor

github-actionsbot commentedNov 5, 2025
edited
Loading

E2E results are ready!

@emrysalemrysal merged commitef4be48 intocalcom:mainNov 9, 2025
32 of 36 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cubic-dev-aicubic-dev-ai[bot]cubic-dev-ai[bot] left review comments

@emrysalemrysalemrysal approved these changes

Assignees

No one assigned

Labels

🐛 bugSomething isn't workingcommunityCreated by Linear-GitHub Synccommunity-internsThe team responsible for reviewing, testing and shipping low/medium community PRsready-for-e2esize/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicating an event type to an existing slug triggers unexpected error; but it's expected.

4 participants

@dhairyashiil@emrysal@keithwillcode@anikdhabal

[8]ページ先頭

©2009-2025 Movatter.jp