Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: filter out platform organizations from admin organization list#24926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@sean-brydon
Copy link
Member

What does this PR do?

Filters out platform organizations from the admin organization list by addingisPlatform: false to the query filter inadminGetAll.handler.ts.

Requested by:sean@cal.com (@sean-brydon)
Devin Session:https://app.devin.ai/sessions/9c26a1afb0a2496a80f5427c9d0de950

Changes Made

  • AddedisPlatform: false filter to theadminGetAll handler to exclude platform organizations from the admin organization list view
  • Fixed ESLint warning by replacing empty object pattern with_opts parameter

How should this be tested?

  1. Navigate to the admin organizations page at/settings/admin/organizations
  2. Verify that organizations withisPlatform: true are no longer visible in the list
  3. Verify that regular organizations (withisPlatform: false or null) are still displayed correctly
  4. Check that all existing functionality (edit, delete, publish, etc.) still works for visible organizations

Note: This change was not tested locally. Manual verification is recommended.

Important Review Notes

⚠️Please verify the interpretation: The requirement was to "set isPlatform: false when pulling back this data". This PR interprets that as filtering OUT platform organizations (i.e., only showing organizations whereisPlatform is false). Please confirm this is the correct interpretation.

⚠️No automated tests added: This PR does not include automated tests for the new filtering behavior.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require adocumentation change. If N/A, write N/A here and check the checkbox. -N/A: This is a simple filter addition that doesn't require documentation changes.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works. -N/A: No automated tests added for this simple filter change.

Checklist

  • I have read thecontributing guide
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas -N/A: The change is self-explanatory
  • I have checked if my changes generate no new warnings - Verified via type-check comparison with main branch

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Contributor

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

@sean-brydonsean-brydon marked this pull request as ready for reviewNovember 21, 2025 11:32
@graphite-appgraphite-appbot requested a review froma teamNovember 21, 2025 11:32
@vercel
Copy link

vercelbot commentedNov 21, 2025
edited
Loading

The latest updates on your projects. Learn more aboutVercel for GitHub.

2 Skipped Deployments
ProjectDeploymentPreviewCommentsUpdated (UTC)
calIgnoredIgnoredNov 21, 2025 11:32am
cal-euIgnoredIgnoredNov 21, 2025 11:32am

@sean-brydonsean-brydonenabled auto-merge (squash)November 21, 2025 11:36
Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 1 file

@sean-brydonsean-brydon merged commit3c8215a intomainNov 21, 2025
57 of 60 checks passed
@sean-brydonsean-brydon deleted the devin/admin-org-list-filter-platform-1762293179 branchNovember 21, 2025 12:03
@github-actions
Copy link
Contributor

E2E results are ready!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cubic-dev-aicubic-dev-ai[bot]cubic-dev-ai[bot] left review comments

@eunjae-leeeunjae-leeeunjae-lee approved these changes

Assignees

No one assigned

Labels

consumercorearea: core, team members onlyready-for-e2esize/XSStale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sean-brydon@eunjae-lee@keithwillcode

[8]ページ先頭

©2009-2025 Movatter.jp