NotificationsYou must be signed in to change notification settings
Fork11.2k
Star39k

style: fix dropdown spacing issues#24917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sean-brydon merged 5 commits intomainfromfix/event-dropdown

Nov 10, 2025

Merged

style: fix dropdown spacing issues#24917

sean-brydon merged 5 commits intomainfromfix/event-dropdown

Nov 10, 2025

Conversation

Copy link

Contributor

pasqualevitiello commentedNov 4, 2025•
edited
Loading

What does this PR do?

This PR fixes some spacing issues on the edit event dropdown.

Visual Demo (For contributors especially)

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require adocumentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Are there environment variables that should be set?
What are the minimal test data to have?
What is expected (happy path) to have (input and output)?
Any other important info that could help to test that PR

Checklist

I haven't read thecontributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

style: fix dropdown spacing issues

c19e018

pull-request-sizebot added the size/S label

Nov 4, 2025

Copy link

vercelbot commentedNov 4, 2025

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: cal-eu.

View Documentation:https://vercel.com/docs/accounts/team-members-and-roles

Copy link

CLAassistant commentedNov 4, 2025•
edited
Loading

All committers have signed the CLA.

keithwillcode added the corearea: core, team members only label

Nov 4, 2025

sean-brydon approved these changes

Nov 4, 2025

View reviewed changes

graphite-appbot added the ready-for-e2e label

Nov 4, 2025

sean-brydonenabled auto-merge (squash)

November 4, 2025 16:32

cubic-dev-aibot reviewed

Nov 4, 2025

View reviewed changes

Copy link

Contributor

cubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.<file name="apps/web/components/booking/BookingActionsDropdown.tsx"><violation number="1" location="apps/web/components/booking/BookingActionsDropdown.tsx:517">`DropdownMenuLabel` already ships with `px-2 pb-1 pt-1.5`, so adding `p-2` doesn’t override the vertical padding—Tailwind’s directional paddings still win and the spacing fix never lands. Use an `!important` vertical padding override instead to get the intended spacing.</violation></file>

_{React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.}

apps/web/components/booking/BookingActionsDropdown.tsx

		<DropdownMenuPortal>
		<DropdownMenuContent>
		<DropdownMenuLabelclassName="px-2 pb-1 pt-1.5">{t("edit_event")}</DropdownMenuLabel>
		<DropdownMenuLabelclassName="p-2">{t("edit_event")}</DropdownMenuLabel>

Copy link

Contributor

cubic-dev-aibotNov 4, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

DropdownMenuLabel already ships withpx-2 pb-1 pt-1.5, so addingp-2 doesn’t override the vertical padding—Tailwind’s directional paddings still win and the spacing fix never lands. Use an!important vertical padding override instead to get the intended spacing.

Prompt for AI agents

Address the following comment on apps/web/components/booking/BookingActionsDropdown.tsx at line 517:<comment>`DropdownMenuLabel` already ships with `px-2 pb-1 pt-1.5`, so adding `p-2` doesn’t override the vertical padding—Tailwind’s directional paddings still win and the spacing fix never lands. Use an `!important` vertical padding override instead to get the intended spacing.</comment><file context>@@ -514,7 +514,7 @@ export function BookingActionsDropdown({ booking }: BookingActionsDropdownProps)         &lt;DropdownMenuPortal&gt;           &lt;DropdownMenuContent&gt;-            &lt;DropdownMenuLabel className=&quot;px-2 pb-1 pt-1.5&quot;&gt;{t(&quot;edit_event&quot;)}&lt;/DropdownMenuLabel&gt;+            &lt;DropdownMenuLabel className=&quot;p-2&quot;&gt;{t(&quot;edit_event&quot;)}&lt;/DropdownMenuLabel&gt;             {editEventActions.map((action) =&gt; (               &lt;DropdownMenuItem className=&quot;rounded-lg&quot; key={action.id} disabled={action.disabled}&gt;</file context>

Suggested change