Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: skip email verification for reschedules and added test case#24867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@kartik-212004
Copy link
Contributor

@kartik-212004kartik-212004 commentedNov 3, 2025•
edited
Loading

Enable rescheduling without requiring booker email verification#24850

What does this PR do?

This PR allows users to reschedule appointments without requiring email verification, even when "Requires booker email verification" is enabled on the event type. Email verification is still enforced for new bookings to maintain security.

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change(video / image - any one).

Before:

Your.booking.has.been.confirmed._.Cal.com.-.4.November.2025.mp4

After:

after.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.N/A - Internal booking flow logic
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Run automated tests:

yarntest packages/features/bookings/lib/handleNewBooking/test/email-verification-booking.test.ts -- --integrationTestsOnly

@kartik-212004kartik-212004 requested a review froma team as acode ownerNovember 3, 2025 11:21
@vercel
Copy link

vercelbot commentedNov 3, 2025

@kartik-212004 is attempting to deploy a commit to thecal Team onVercel.

A member of the Team first needs toauthorize it.

@graphite-appgraphite-appbot added the communityCreated by Linear-GitHub Sync labelNov 3, 2025
@github-actionsgithub-actionsbot added consumer High priorityCreated by Linear-GitHub Sync 🐛 bugSomething isn't working labelsNov 3, 2025
@CLAassistant
Copy link

CLAassistant commentedNov 3, 2025•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@graphite-appgraphite-appbot requested a review froma teamNovember 3, 2025 11:21
Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 2 files

@kartik-212004kartik-212004force-pushed thefix/skip-email-verification-on-reschedule branch frombb61fa0 tocf66c0cCompareNovember 3, 2025 12:38
Copy link
Member

@dhairyashiildhairyashiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please attach before and after loom video, making it draft until then.

@dhairyashiildhairyashiil marked this pull request as draftNovember 3, 2025 19:10
@kartik-212004
Copy link
ContributorAuthor

Please attach before and after loom video, making it draft until then.

added before and after video

@dhairyashiildhairyashiil marked this pull request as ready for reviewNovember 3, 2025 20:46
Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 2 files

@dhairyashiil
Copy link
Member

Hello@kartik-212004, thank you for the PR.

  1. What happens if someone tries to reschedule with a different email address than the original attendee?
  2. Have you added the same logic for other types of bookings, such as seated?

@kartik-212004
Copy link
ContributorAuthor

Hello@kartik-212004, thank you for the PR.

  1. What happens if someone tries to reschedule with a different email address than the original attendee?
  2. Have you added the same logic for other types of bookings, such as seated?

The email field is disabled during rescheduling, so you cannot use a different email address.

image

@dhairyashiil
Copy link
Member

The email field is disabled during rescheduling, so you cannot use a different email address.

looks good 👍🏼

  1. Have you added the same logic for other types of bookings, such as seated?

what about this?

@kartik-212004
Copy link
ContributorAuthor

The email field is disabled during rescheduling, so you cannot use a different email address.

looks good 👍🏼

  1. Have you added the same logic for other types of bookings, such as seated?

what about this?

Yes its implemented for the seated booking aswell.

dhairyashiil reacted with thumbs up emoji

@dhairyashiil
Copy link
Member

Everything looks good Kartik. Please fix the failing test. I think that’s the only thing left

@kartik-212004
Copy link
ContributorAuthor

Everything looks good Kartik. Please fix the failing test. I think that’s the only thing left

Thanks for the feedback@dhairyashiil , i will fix the failing test

@dhairyashiildhairyashiil marked this pull request as draftNovember 4, 2025 10:18
Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 1 file

@kartik-212004
Copy link
ContributorAuthor

@dhairyashiil fixed failing test

@dhairyashiildhairyashiil marked this pull request as ready for reviewNovember 4, 2025 13:38
@dhairyashiil
Copy link
Member

Okay, I will check. Btw please sign CLA:comment

kartik-212004 reacted with thumbs up emoji

Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 2 files

Copy link
Contributor

@Udit-takkarUdit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

dhairyashiil and kartik-212004 reacted with heart emoji
@Udit-takkarUdit-takkarenabled auto-merge (squash)November 5, 2025 07:32
@github-actions
Copy link
Contributor

github-actionsbot commentedNov 5, 2025•
edited
Loading

E2E results are ready!

@Udit-takkarUdit-takkar merged commit228fbaf intocalcom:mainNov 11, 2025
56 of 62 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cubic-dev-aicubic-dev-ai[bot]cubic-dev-ai[bot] left review comments

@emrysalemrysalemrysal approved these changes

@Udit-takkarUdit-takkarUdit-takkar approved these changes

@dhairyashiildhairyashiilAwaiting requested review from dhairyashiil

Assignees

No one assigned

Labels

🐛 bugSomething isn't workingcommunityCreated by Linear-GitHub SyncconsumerHigh priorityCreated by Linear-GitHub Syncready-for-e2esize/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable rescheduling without requiring booker email verification

6 participants

@kartik-212004@CLAassistant@dhairyashiil@emrysal@Udit-takkar@anikdhabal
[8]ページ先頭
©2009-2025 Movatter.jp